Chromium Code Reviews Chromium Code Reviews
Issue 26659002:
rebaseline_server: extend returned JSON dict to allow for result-editing in coming CL (Closed)
Base URL: http://skia.googlecode.com/svn/trunk/| Index: gm/rebaseline_server/static/view.html |
| =================================================================== |
| --- gm/rebaseline_server/static/view.html (revision 11659) |
| +++ gm/rebaseline_server/static/view.html (working copy) |
| @@ -11,10 +11,6 @@ |
| <body> |
| <div ng-controller="Loader.Controller"> |
| - <!-- TODO(epoger): Add a warning banner if the server is running in |
| - --export mode |
| - --> |
| - |
| <!-- TODO(epoger): Add some indication of how old the |
| expected/actual data is --> |
| @@ -23,6 +19,11 @@ |
| </em> |
| <div ng-hide="!categories"> |
| + <div ng-hide="!(header['is-editable'] && header['is-exported'])" |
|
jcgregorio
2013/10/09 14:41:48
If you rename 'is-editable' to 'is_editable' then
epoger
2013/10/09 15:35:30
Done.
|
| + style="background-color:#ffbb00"> |
| + WARNING! These results are editable and exported, so any user |
| + who can connect to this server over the network can modify them. |
| + </div> |
| <table border="1"> |
| <tr> |
| <th colspan="2"> |
| @@ -131,6 +132,10 @@ |
| ng-click="sortResultsBy('actualHashDigest')"> |
| actual image |
| </th> |
| + <th ng-hide="!header['is-editable']"> |
| + <!-- item-selection checkbox column --> |
| + {{selectedItems}} <!-- TODO(epoger): temporary debug output --> |
| + </th> |
| </tr> |
| <tr ng-repeat="result in limitedTestData"> |
| <td>{{result.resultType}}</td> |
| @@ -147,6 +152,12 @@ |
| <img width="{{imageSize}}" src="http://chromium-skia-gm.commondatastorage.googleapis.com/gm/{{result.actualHashType}}/{{result.test}}/{{result.actualHashDigest}}.png"/> |
| </a> |
| </td> |
| + <td ng-hide="!header['is-editable']"> |
|
epoger
2013/10/09 05:52:16
I have set is-editable to True in testing, and con
|
| + <input type="checkbox" |
| + name="rowSelect" |
| + value="{{result.index}}" |
| + ng-checked="isItemSelected(result.index)" |
| + ng-click="toggleItemSelected(result.index)"> |
| </tr> |
| </table> |
| </div> |
