rebaseline_server: extend returned JSON dict to allow for result-editing in coming CL

rebaseline_server: extend returned JSON dict to allow for result-editing in coming CL
(SkipBuildbotRuns)

R=jcgregorio@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11679

[epoger, 2013-10-09 05:52:16]

Ready for review at patchset 1.

There are no user-visible changes in this CL, so I haven't left it up and
running.

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results....
gm/rebaseline_server/results.py:81: "index": 0,   # index of this result within
testData list
We may or may not use these indices when sending modifications back to the
server... but they will definitely be useful for tracking checked/unchecked test
results on the client side.

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/v...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:155: <td ng-hide="!header['is-editable']">
I have set is-editable to True in testing, and confirmed that the checkboxes
work as expected.  In a coming CL, I will do more with item selection
(primarily: tell server to approve selected results)

[jcgregorio, 2013-10-09 14:41:48]

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results....
gm/rebaseline_server/results.py:3: '''
What Python coding standard are we using?

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:45: $scope.selectedItems = [];
Making this an {} would simplify the code since you can use numbers as keys, and
a request for an item not in the object returns undefined.

 a = {};
 > a = {}
 Object {}
 > a[1] = true
 true
 > a[1] == true
 true
 > a[2] == true
 false

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:52: return
($scope.selectedItems.indexOf(index) >= 0);
If you don't switch to using a map, then this should change to 
  != -1. Here and below.

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/v...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:22: <div ng-hide="!(header['is-editable']
&& header['is-exported'])"
If you rename 'is-editable' to 'is_editable' then you can access is more easily
as:

  !(header.is_editable && header.is_exported)

[epoger, 2013-10-09 15:35:29]

Thanks, Joe!  Please see patchset 3.

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results....
gm/rebaseline_server/results.py:3: '''
On 2013/10/09 14:41:48, jcgregorio wrote:
> What Python coding standard are we using?

All of them. :-)

But seriously, folks,
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
does not specify any Python style guidelines.  I guess we should pick one.  Any
suggestions, Joe?

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:45: $scope.selectedItems = [];
On 2013/10/09 14:41:48, jcgregorio wrote:
> Making this an {} would simplify the code since you can use numbers as keys,
and
> a request for an item not in the object returns undefined.

Great idea!  Done.

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:52: return
($scope.selectedItems.indexOf(index) >= 0);
On 2013/10/09 14:41:48, jcgregorio wrote:
> If you don't switch to using a map, then this should change to 
>   != -1. Here and below.

Switched to map.

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/v...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:22: <div ng-hide="!(header['is-editable']
&& header['is-exported'])"
On 2013/10/09 14:41:48, jcgregorio wrote:
> If you rename 'is-editable' to 'is_editable' then you can access is more
easily
> as:
> 
>   !(header.is_editable && header.is_exported)

Done.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/stat...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/stat...
gm/rebaseline_server/static/loader.js:21: var item = unfilteredItems[i];
Fixed tabs to spaces again, argh

[borenet, 2013-10-09 15:43:17]

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results....
gm/rebaseline_server/results.py:3: '''
On 2013/10/09 15:35:30, epoger wrote:
> On 2013/10/09 14:41:48, jcgregorio wrote:
> > What Python coding standard are we using?
> 
> All of them. :-)
> 
> But seriously, folks,
>
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
> does not specify any Python style guidelines.  I guess we should pick one. 
Any
> suggestions, Joe?

I thought we were using the Google style guide:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html

Though it's not documented and we're certainly not strict...

[jcgregorio, 2013-10-09 15:49:47]

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results....
gm/rebaseline_server/results.py:3: '''
OK, the code looks close to that style, but I didn't want to start suggesting
changes until I knew which guide we were following.

On 2013/10/09 15:43:17, borenet wrote:
> On 2013/10/09 15:35:30, epoger wrote:
> > On 2013/10/09 14:41:48, jcgregorio wrote:
> > > What Python coding standard are we using?
> > 
> > All of them. :-)
> > 
> > But seriously, folks,
> >
>
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
> > does not specify any Python style guidelines.  I guess we should pick one. 
> Any
> > suggestions, Joe?
> 
> I thought we were using the Google style guide:
> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
> 
> Though it's not documented and we're certainly not strict...

Yeah, updating the docs to point to that would be good. If someone wants to add
me to the site I can do it.

[scroggo, 2013-10-09 16:19:22]

On 2013/10/09 15:49:47, jcgregorio wrote:
>
https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results.py
> File gm/rebaseline_server/results.py (right):
> 
>
https://codereview.chromium.org/26659002/diff/1/gm/rebaseline_server/results....
> gm/rebaseline_server/results.py:3: '''
> OK, the code looks close to that style, but I didn't want to start suggesting
> changes until I knew which guide we were following.
> 
> On 2013/10/09 15:43:17, borenet wrote:
> > On 2013/10/09 15:35:30, epoger wrote:
> > > On 2013/10/09 14:41:48, jcgregorio wrote:
> > > > What Python coding standard are we using?
> > > 
> > > All of them. :-)
> > > 
> > > But seriously, folks,
> > >
> >
>
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
> > > does not specify any Python style guidelines.  I guess we should pick one.

> > Any
> > > suggestions, Joe?
> > 
> > I thought we were using the Google style guide:
> > http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
> > 
> > Though it's not documented and we're certainly not strict...
> 
> Yeah, updating the docs to point to that would be good. If someone wants to
add
> me to the site I can do it.

You can now edit (I think)!

[jcgregorio, 2013-10-09 16:34:25]

Just some style nits.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:3: '''
Triple double quotes, not triple single quotes.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:10: '''
Keep all in one pydoc comment.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:206: "index": len(test_data),
Single quotes for strings.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/serv...
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/serv...
gm/rebaseline_server/server.py:181: """ Handle a GET request for a file under
the 'static' directory.
Document params in pydoc, here and below.

[epoger, 2013-10-09 17:49:17]

Thanks for getting me to Keep It Clean.  Please see patchset 4.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:3: '''
On 2013/10/09 16:34:25, jcgregorio wrote:
> Triple double quotes, not triple single quotes.

Done.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:10: '''
On 2013/10/09 16:34:25, jcgregorio wrote:
> Keep all in one pydoc comment.

Done.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
gm/rebaseline_server/results.py:206: "index": len(test_data),
On 2013/10/09 16:34:25, jcgregorio wrote:
> Single quotes for strings.

Done.

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/serv...
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/serv...
gm/rebaseline_server/server.py:181: """ Handle a GET request for a file under
the 'static' directory.
On 2013/10/09 16:34:25, jcgregorio wrote:
> Document params in pydoc, here and below.

Done.

[jcgregorio, 2013-10-09 17:51:57]

On 2013/10/09 17:49:17, epoger wrote:
> Thanks for getting me to Keep It Clean.  Please see patchset 4.
> 
>
https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
> File gm/rebaseline_server/results.py (right):
> 
>
https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
> gm/rebaseline_server/results.py:3: '''
> On 2013/10/09 16:34:25, jcgregorio wrote:
> > Triple double quotes, not triple single quotes.
> 
> Done.
> 
>
https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
> gm/rebaseline_server/results.py:10: '''
> On 2013/10/09 16:34:25, jcgregorio wrote:
> > Keep all in one pydoc comment.
> 
> Done.
> 
>
https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/resu...
> gm/rebaseline_server/results.py:206: "index": len(test_data),
> On 2013/10/09 16:34:25, jcgregorio wrote:
> > Single quotes for strings.
> 
> Done.
> 
>
https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/serv...
> File gm/rebaseline_server/server.py (right):
> 
>
https://codereview.chromium.org/26659002/diff/12001/gm/rebaseline_server/serv...
> gm/rebaseline_server/server.py:181: """ Handle a GET request for a file under
> the 'static' directory.
> On 2013/10/09 16:34:25, jcgregorio wrote:
> > Document params in pydoc, here and below.
> 
> Done.

LGTM

[epoger, 2013-10-09 18:06:03]

Committed patchset #4 manually as r11679 (presubmit successful).