Issue 2665853002: [Media Router][Extension] Fix missing dependency on url/mojo/origin.mojom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2665853002: [Media Router][Extension] Fix missing dependency on url/mojo/origin.mojom

Created:
3 years, 10 months ago by imcheng

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Media Router][Extension] Fix missing dependency on url/mojo/origin.mojom https://codereview.chromium.org/2627463003 refactored code to use origin.mojom. But we also needed to ensure it is available in the context of an extension. TODO: change media_router_bindings.js to use Origin instead of string. BUG=686832, 686836

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	extensions/renderer/dispatcher.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	extensions/renderer/resources/extensions_renderer_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

imcheng

3 years, 10 months ago (2017-01-30 21:17:41 UTC) #1

Description was changed from

==========
[Media Router][Extension] Fix missing dependency on url/mojo/origin.mojom

https://codereview.chromium.org/2627463003 refactored code to use
origin.mojom. But we also needed to ensure it is available in the
context of an extension.

Also, this patch changes media_router_bindings.js to use Origin instead
of string.


BUG=686832,686836
==========

to

==========
[Media Router][Extension] Fix missing dependency on url/mojo/origin.mojom

https://codereview.chromium.org/2627463003 refactored code to use
origin.mojom. But we also needed to ensure it is available in the
context of an extension.

TODO: change media_router_bindings.js to use Origin instead of
string.


BUG=686832,686836
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages