Issue 266583002: Switch WebIDBDatabase::put over to the version with blobs.

Issue 266583002: Switch WebIDBDatabase::put over to the version with blobs. (Closed)

Created:
6 years, 7 months ago by ericu

Modified:
6 years, 7 months ago

Reviewers:
jsbell, cmumford, abarth-chromium

CC:
blink-reviews, jamesr, alecflett, ericu+idb_chromium.org, abarth-chromium, dglazkov+blink, dgrogan, cmumford, jsbell+idb_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Switch WebIDBDatabase::put over to the version with blobs. Also, remove the shims in the other direction [WebIDBCallbacks], now that the Chromium side has landed. BUG=108012 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173337

Patch Set 1 #

Patch Set 2 : Remove the shims. #

Patch Set 3 : Update calls. #

Total comments: 4

Patch Set 4 : Cleanup from code review #

Total comments: 1

Patch Set 5 : Even better! #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -44 lines)			Patch
M	Source/modules/indexeddb/IDBObjectStore.cpp	View	1 2 3 4	4 chunks	+10 lines, -2 lines	0 comments	Download
M	Source/modules/indexeddb/WebIDBCallbacksImpl.h	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/modules/indexeddb/WebIDBCallbacksImpl.cpp	View	1	3 chunks	+0 lines, -24 lines	0 comments	Download
M	public/platform/WebIDBCallbacks.h	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	public/platform/WebIDBDatabase.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

jsbell

https://codereview.chromium.org/266583002/diff/40001/Source/modules/indexeddb/IDBObjectStore.cpp File Source/modules/indexeddb/IDBObjectStore.cpp (right): https://codereview.chromium.org/266583002/diff/40001/Source/modules/indexeddb/IDBObjectStore.cpp#newcode182 Source/modules/indexeddb/IDBObjectStore.cpp:182: remove extra blank line https://codereview.chromium.org/266583002/diff/40001/Source/modules/indexeddb/IDBObjectStore.cpp#newcode248 Source/modules/indexeddb/IDBObjectStore.cpp:248: if (info.isFile()) Move ...

6 years, 7 months ago (2014-04-30 21:38:33 UTC) #2

ericu

https://codereview.chromium.org/266583002/diff/40001/Source/modules/indexeddb/IDBObjectStore.cpp File Source/modules/indexeddb/IDBObjectStore.cpp (right): https://codereview.chromium.org/266583002/diff/40001/Source/modules/indexeddb/IDBObjectStore.cpp#newcode182 Source/modules/indexeddb/IDBObjectStore.cpp:182: On 2014/04/30 21:38:33, jsbell wrote: > remove extra blank ...

6 years, 7 months ago (2014-04-30 22:30:43 UTC) #3

jsbell

lgtm https://codereview.chromium.org/266583002/diff/60001/Source/modules/indexeddb/IDBObjectStore.cpp File Source/modules/indexeddb/IDBObjectStore.cpp (right): https://codereview.chromium.org/266583002/diff/60001/Source/modules/indexeddb/IDBObjectStore.cpp#newcode243 Source/modules/indexeddb/IDBObjectStore.cpp:243: WebVector<WebBlobInfo> webBlobInfo = blobInfo; Do you even need ...

6 years, 7 months ago (2014-04-30 23:43:17 UTC) #4

ericu

On 2014/04/30 23:43:17, jsbell wrote: > lgtm > > https://codereview.chromium.org/266583002/diff/60001/Source/modules/indexeddb/IDBObjectStore.cpp > File Source/modules/indexeddb/IDBObjectStore.cpp (right): > ...

6 years, 7 months ago (2014-05-01 04:16:51 UTC) #5

ericu

+abarth for platform/public changes. Adam, this is almost the last one of the IDB/Blob stuff; ...

6 years, 7 months ago (2014-05-05 17:57:06 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/266583002/80001

6 years, 7 months ago (2014-05-05 19:40:29 UTC) #10

Message was sent while issue was closed.

Change committed as 173337

Expand Messages | Collapse Messages