Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2665823002: Invalidate caret during paint invalidation (Closed)
Patch Set: NeedsRebaseline Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index 59481168c6b51d0c2b527e6ed4771f5c0aa0e833..e913d31e1340f849c08cc1f8b86a41dd5aee504c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1514,13 +1514,11 @@ StyleDifference LayoutObject::adjustStyleDifference(
// needed if we have style or text affected by these properties.
if (diff.textDecorationOrColorChanged() && !diff.needsPaintInvalidation()) {
if (style()->hasBorder() || style()->hasOutline() ||
- style()->hasBackgroundRelatedColorReferencingCurrentColor()
+ style()->hasBackgroundRelatedColorReferencingCurrentColor() ||
// Skip any text nodes that do not contain text boxes. Whitespace cannot
// be skipped or we will miss invalidating decorations (e.g.,
// underlines).
- || (isText() && !isBR() && toLayoutText(this)->hasTextBoxes())
- // Caret is painted in text color.
- || (isLayoutBlock() && toLayoutBlock(this)->hasCaret()) ||
+ (isText() && !isBR() && toLayoutText(this)->hasTextBoxes()) ||
(isSVG() && style()->svgStyle().isFillColorCurrentColor()) ||
(isSVG() && style()->svgStyle().isStrokeColorCurrentColor()) ||
isListMarker())
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/paint/BlockPaintInvalidator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698