Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 2665823002: Invalidate caret during paint invalidation (Closed)
Patch Set: NeedsRebaseline Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index d2014ceca0ec4cc5096d16ab95235954deaecd7b..7b4fdaf733585d3023908794230f86783edcfede 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -486,9 +486,11 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
bool isSelectionRoot() const;
public:
- bool hasCursorCaret() const;
- bool hasDragCaret() const;
- bool hasCaret() const { return hasCursorCaret() || hasDragCaret(); }
+ bool shouldPaintCursorCaret() const;
+ bool shouldPaintDragCaret() const;
+ bool shouldPaintCarets() const {
+ return shouldPaintCursorCaret() || shouldPaintDragCaret();
+ }
protected:
PaintInvalidationReason invalidatePaintIfNeeded(
@@ -496,6 +498,8 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
PaintInvalidationReason invalidatePaintIfNeeded(
const PaintInvalidatorContext&) const override;
+ void clearPreviousVisualRects() override;
+
private:
LayoutRect localCaretRect(InlineBox*,
int caretOffset,
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698