Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2665823002: Invalidate caret during paint invalidation (Closed)
Patch Set: NeedsRebaseline Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index 3ca0cfd355c6d80e77759bba54e4ae7b9ded7049..73f1e72302a9aff5c715f94c7e0fe592d361548d 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -379,9 +379,9 @@ bool isEditablePosition(const Position& position) {
DCHECK(node->document().isActive());
if (node->document().lifecycle().state() >=
DocumentLifecycle::InStyleRecalc) {
- // TODO(yosin): Once we change |LayoutObject::adjustStyleDifference()|
- // not to call |FrameSelection::hasCaret()|, we should not assume
- // calling |isEditablePosition()| in |InStyleRecalc| is safe.
+ // TODO(yosin): Update the condition and DCHECK here given that
+ // https://codereview.chromium.org/2665823002/ avoided this function from
+ // being called during InStyleRecalc.
} else {
DCHECK(!needsLayoutTreeUpdate(position)) << position;
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/DragCaret.cpp ('k') | third_party/WebKit/Source/core/editing/FrameCaret.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698