third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2665823002: Invalidate caret during paint invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2665823002: Invalidate caret during paint invalidation (Closed)

Patch Set: Rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index 3d581f823066b04e47e447e2b2753a9d65cc5915..45b14bf0e9cc97c8d2191872770174245ff69de4 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -410,7 +410,7 @@ void PaintLayerScrollableArea::updateScrollOffset(const ScrollOffset& newOffset,

const LayoutBoxModelObject& paintInvalidationContainer =

box().containerForPaintInvalidation();

// The caret rect needs to be invalidated after scrolling

- frame->selection().setCaretRectNeedsUpdate();

+ frame->selection().setCaretMayNeedPaintInvalidation();

FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect(

layer()->layoutObject()->previousVisualRectIncludingCompositedScrolling(