third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp - Issue 2665823002: Invalidate caret during paint invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

Issue 2665823002: Invalidate caret during paint invalidation (Closed)

Patch Set: Rebaseline Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/BlockPaintInvalidator.cpp ('K') | « third_party/WebKit/Source/core/paint/BlockPaintInvalidatorTest.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInvalidator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp b/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

index 018acd1953f2bd04365bda3a9bc14e14918f4fe2..8e9b6d65ad1d26600dda847048353a06e2aac8e4 100644

--- a/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp

@@ -72,11 +72,9 @@ TEST_P(PaintControllerPaintTestForSlimmingPaintV1AndV2,

TestDisplayItem(*layoutView().layer(), DisplayItem::kSubsequence),

TestDisplayItem(layoutView(), documentBackgroundType),

TestDisplayItem(textInlineBox, foregroundType),

- TestDisplayItem(document()

- .frame()

- ->selection()

- .caretDisplayItemClientForTesting(),

- DisplayItem::kCaret), // New!

+ TestDisplayItem(

+ document().frame()->selection().getCaretDisplayItemClient(),

+ DisplayItem::kCaret), // New!

TestDisplayItem(*layoutView().layer(), DisplayItem::kEndSubsequence));

} else {

EXPECT_DISPLAY_LIST(

@@ -86,11 +84,9 @@ TEST_P(PaintControllerPaintTestForSlimmingPaintV1AndV2,

TestDisplayItem(*layoutView().layer(), DisplayItem::kSubsequence),

TestDisplayItem(layoutView(), documentBackgroundType),

TestDisplayItem(textInlineBox, foregroundType),

- TestDisplayItem(document()

- .frame()

- ->selection()

- .caretDisplayItemClientForTesting(),

- DisplayItem::kCaret), // New!

+ TestDisplayItem(

+ document().frame()->selection().getCaretDisplayItemClient(),

+ DisplayItem::kCaret), // New!

TestDisplayItem(*layoutView().layer(), DisplayItem::kEndSubsequence),

TestDisplayItem(layoutView(),

DisplayItem::clipTypeToEndClipType(

@@ -102,7 +98,7 @@ TEST_P(PaintControllerPaintTestForSlimmingPaintV1AndV2,

TestDisplayItem(layoutView(), documentBackgroundType),

TestDisplayItem(textInlineBox, foregroundType),

TestDisplayItem(

- document().frame()->selection().caretDisplayItemClientForTesting(),

+ document().frame()->selection().getCaretDisplayItemClient(),

DisplayItem::kCaret)); // New!

}