Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2665823002: Invalidate caret during paint invalidation (Closed)
Patch Set: Rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index d06a1caa1e8eeb00b209db861ca386bb3eadde08..00a05a9964761d3bcfd4e62b0ffe0dec82dd4494 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1514,13 +1514,11 @@ StyleDifference LayoutObject::adjustStyleDifference(
// needed if we have style or text affected by these properties.
if (diff.textDecorationOrColorChanged() && !diff.needsPaintInvalidation()) {
if (style()->hasBorder() || style()->hasOutline() ||
- style()->hasBackgroundRelatedColorReferencingCurrentColor()
+ style()->hasBackgroundRelatedColorReferencingCurrentColor() ||
// Skip any text nodes that do not contain text boxes. Whitespace cannot
// be skipped or we will miss invalidating decorations (e.g.,
// underlines).
- || (isText() && !isBR() && toLayoutText(this)->hasTextBoxes())
- // Caret is painted in text color.
- || (isLayoutBlock() && toLayoutBlock(this)->hasCaret()) ||
yosin_UTC9 2017/01/31 20:12:58 Finally, You did it! (^_^)b My approach[1] was re
+ (isText() && !isBR() && toLayoutText(this)->hasTextBoxes()) ||
(isSVG() && style()->svgStyle().isFillColorCurrentColor()) ||
(isSVG() && style()->svgStyle().isStrokeColorCurrentColor()) ||
isListMarker())

Powered by Google App Engine
This is Rietveld 408576698