Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2665823002: Invalidate caret during paint invalidation (Closed)
Patch Set: NeedsRebaseline Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 // has finished. 402 // has finished.
403 layer()->updateLayerPositionsAfterOverflowScroll(); 403 layer()->updateLayerPositionsAfterOverflowScroll();
404 // Update regions, scrolling may change the clip of a particular region. 404 // Update regions, scrolling may change the clip of a particular region.
405 frameView->updateDocumentAnnotatedRegions(); 405 frameView->updateDocumentAnnotatedRegions();
406 frameView->setNeedsUpdateWidgetGeometries(); 406 frameView->setNeedsUpdateWidgetGeometries();
407 updateCompositingLayersAfterScroll(); 407 updateCompositingLayersAfterScroll();
408 } 408 }
409 409
410 const LayoutBoxModelObject& paintInvalidationContainer = 410 const LayoutBoxModelObject& paintInvalidationContainer =
411 box().containerForPaintInvalidation(); 411 box().containerForPaintInvalidation();
412 // The caret rect needs to be invalidated after scrolling
413 frame->selection().setCaretRectNeedsUpdate();
414 412
415 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect( 413 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect(
416 layer()->layoutObject()->previousVisualRectIncludingCompositedScrolling( 414 layer()->layoutObject()->previousVisualRectIncludingCompositedScrolling(
417 paintInvalidationContainer))); 415 paintInvalidationContainer)));
418 416
419 quadForFakeMouseMoveEvent = 417 quadForFakeMouseMoveEvent =
420 paintInvalidationContainer.localToAbsoluteQuad(quadForFakeMouseMoveEvent); 418 paintInvalidationContainer.localToAbsoluteQuad(quadForFakeMouseMoveEvent);
421 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad( 419 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(
422 quadForFakeMouseMoveEvent); 420 quadForFakeMouseMoveEvent);
423 421
(...skipping 1676 matching lines...) Expand 10 before | Expand all | Expand 10 after
2100 2098
2101 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2099 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2102 clampScrollableAreas() { 2100 clampScrollableAreas() {
2103 for (auto& scrollableArea : *s_needsClamp) 2101 for (auto& scrollableArea : *s_needsClamp)
2104 scrollableArea->clampScrollOffsetAfterOverflowChange(); 2102 scrollableArea->clampScrollOffsetAfterOverflowChange();
2105 delete s_needsClamp; 2103 delete s_needsClamp;
2106 s_needsClamp = nullptr; 2104 s_needsClamp = nullptr;
2107 } 2105 }
2108 2106
2109 } // namespace blink 2107 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698