Invalidate caret during paint invalidation

third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/caret-contenteditable-content-after-expected.txt

 {
   "layers": [
     {
       "name": "LayoutView #document",
       "bounds": [800, 600],
       "contentsOpaque": true,
       "drawsContent": true,
       "paintInvalidations": [
         {
           "object": "LayoutBlockFlow DIV id='editor'",
@@ skipping 52 matching lines @@
         },
         {
           "object": "LayoutText #text",
           "rect": [8, 48, 7, 19],
           "reason": "layoutObject insertion"
         },
         {
           "object": "LayoutTextFragment (anonymous)",
           "rect": [8, 48, 7, 19],
           "reason": "forced by layout"
-        },

[chrishtr, 2017/01/31 22:51:03]

Shouldn't there be at least one new invalidation to replace this list?

[Xianzhu, 2017/02/02 23:42:06]

Now we skip caret rect invalidation if its containing block is doing full
invalidation. We have full rect invalidation at line 10-28.

We still invalidate the display item client of the caret.

-        {
-          "object": "LayoutBlockFlow DIV id='editor'",
-          "rect": [7, 47, 3, 22],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutBlockFlow DIV id='editor'",
-          "rect": [7, 47, 3, 22],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutBlockFlow DIV id='editor'",
-          "rect": [7, 47, 3, 22],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutBlockFlow DIV id='editor'",
-          "rect": [7, 47, 3, 22],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [29, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [29, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [29, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [22, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [22, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [22, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [22, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [14, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [14, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [14, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
-        },
-        {
-          "object": "LayoutText #text",
-          "rect": [14, 47, 3, 21],
-          "reason": "invalidate paint rectangle"
         }
       ]
     }
   ],
   "objectPaintInvalidations": [
     {
-      "object": "Caret",
-      "reason": "invalidate paint rectangle"
-    },
-    {
       "object": "LayoutBlockFlow DIV id='editor'",
       "reason": "style change"
     },
     {
       "object": "RootInlineBox",
       "reason": "style change"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
-    },
-    {
-      "object": "Caret",
-      "reason": "invalidate paint rectangle"
-    },
-    {
-      "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "LayoutBlockFlow DIV id='editor'",
       "reason": "forced by layout"
     },
     {
       "object": "RootInlineBox",
       "reason": "forced by layout"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "LayoutText #text",
       "reason": "layoutObject insertion"
     },
     {
       "object": "InlineTextBox 'a'",
       "reason": "layoutObject insertion"
     },
     {
       "object": "LayoutTextFragment (anonymous)",
       "reason": "forced by layout"
     },
     {
       "object": "InlineTextBox 'x'",
       "reason": "forced by layout"
     },
     {
-      "object": "Caret",
-      "reason": "invalidate paint rectangle"
-    },
-    {
-      "object": "Caret",
-      "reason": "invalidate paint rectangle"
-    },
-    {
       "object": "LayoutBlockFlow DIV id='editor'",
       "reason": "forced by layout"
     },
     {
       "object": "RootInlineBox",
       "reason": "forced by layout"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "LayoutText #text",
       "reason": "full"
     },
     {
       "object": "InlineTextBox 'ab'",
       "reason": "full"
     },
     {
       "object": "LayoutTextFragment (anonymous)",
       "reason": "forced by layout"
     },
     {
       "object": "InlineTextBox 'x'",
       "reason": "forced by layout"
     },
     {
-      "object": "Caret",
-      "reason": "invalidate paint rectangle"
-    },
-    {
-      "object": "Caret",
-      "reason": "invalidate paint rectangle"
-    },
-    {
       "object": "LayoutBlockFlow DIV id='editor'",
       "reason": "forced by layout"
     },
     {
       "object": "RootInlineBox",
       "reason": "forced by layout"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "Caret",
-      "reason": "invalidate paint rectangle"
+      "reason": "caret"
     },
     {
       "object": "LayoutText #text",
       "reason": "full"
     },
     {
       "object": "InlineTextBox 'abc'",
       "reason": "full"
     },
     {
       "object": "LayoutTextFragment (anonymous)",
       "reason": "forced by layout"
     },
     {
       "object": "InlineTextBox 'x'",
       "reason": "forced by layout"
     }
   ]
 }