Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: components/ntp_snippets/remote/json_request.h

Issue 2665743002: [Remote suggestions] Clean up variation params in the fetcher. (Closed)
Patch Set: Further changes & unit-test fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/json_request.h
diff --git a/components/ntp_snippets/remote/json_request.h b/components/ntp_snippets/remote/json_request.h
index c7c73c7767e6755551b772c8e04a61457e7fb681..423d44c7cd27054820094fc03331fe2548ba360f 100644
--- a/components/ntp_snippets/remote/json_request.h
+++ b/components/ntp_snippets/remote/json_request.h
@@ -24,7 +24,6 @@ class TickClock;
} // namespace base
class FetchAPI;
-class Personalization;
namespace ntp_snippets {
class UserClassifier;
@@ -82,7 +81,6 @@ class JsonRequest : public net::URLFetcherDelegate {
Builder& SetLanguageModel(const translate::LanguageModel* language_model);
Builder& SetParams(const RequestParams& params);
Builder& SetParseJsonCallback(ParseJSONCallback callback);
- Builder& SetPersonalization(Personalization personalization);
// The tick_clock borrowed from the fetcher will be injected into the
// request. It will be used at build time and after the fetch returned.
// It has to be alive until the request is destroyed.
@@ -111,11 +109,6 @@ class JsonRequest : public net::URLFetcherDelegate {
const std::string& headers,
const std::string& body) const;
- bool ReturnOnlyPersonalizedResults() const {
- return !obfuscated_gaia_id_.empty() &&
- personalization_ == Personalization::kPersonal;
- }
-
void PrepareLanguages(
translate::LanguageModel::LanguageInfo* ui_language,
translate::LanguageModel::LanguageInfo* other_top_language) const;
@@ -126,7 +119,6 @@ class JsonRequest : public net::URLFetcherDelegate {
FetchAPI fetch_api_;
RequestParams params_;
ParseJSONCallback parse_json_callback_;
- Personalization personalization_;
GURL url_;
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;

Powered by Google App Engine
This is Rietveld 408576698