Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/about_flags.cc

Issue 2665743002: [Remote suggestions] Clean up variation params in the fetcher. (Closed)
Patch Set: Further changes & unit-test fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 4fd3c68be996609d0ccc1711aa0591949014b47f..23c52ab2af630b6eb8ad8130a36b68dda4aec4da 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -540,27 +540,15 @@ const FeatureEntry::FeatureParam kNTPSnippetsFeatureVariationServer[] = {
{"content_suggestions_backend",
ntp_snippets::kContentSuggestionsServer}};
-const FeatureEntry::FeatureParam
jkrcal 2017/02/03 10:17:49 I've forgotten to remove this in the previous patc
- kNTPSnippetsFeatureVariationServerNonPersonalized[] = {
- {"content_suggestions_backend",
- ntp_snippets::kContentSuggestionsServer},
- {"fetching_personalization", "non_personal"}};
-
const FeatureEntry::FeatureVariation kNTPSnippetsFeatureVariations[] = {
{"via ChromeReader", kNTPSnippetsFeatureVariationChromeReader,
arraysize(kNTPSnippetsFeatureVariationChromeReader), nullptr},
{"via content suggestion server (backed by ChromeReader)",
kNTPSnippetsFeatureVariationServer,
arraysize(kNTPSnippetsFeatureVariationServer), nullptr},
- {"via content suggestion server (backed by ChromeReader, non-personalized)",
- kNTPSnippetsFeatureVariationServerNonPersonalized,
- arraysize(kNTPSnippetsFeatureVariationServerNonPersonalized), nullptr},
{"via content suggestion server (backed by Google Now)",
kNTPSnippetsFeatureVariationServer,
- arraysize(kNTPSnippetsFeatureVariationServer), "3313279"},
- {"via content suggestion server (backed by Google Now, non-personalized)",
- kNTPSnippetsFeatureVariationServerNonPersonalized,
- arraysize(kNTPSnippetsFeatureVariationServerNonPersonalized), "3313279"}};
+ arraysize(kNTPSnippetsFeatureVariationServer), "3313279"}};
#endif // OS_ANDROID
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698