chrome/browser/ui/webui/snippets_internals_message_handler.cc - Issue 2665743002: [Remote suggestions] Clean up variation params in the fetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/snippets_internals_message_handler.cc

Issue 2665743002: [Remote suggestions] Clean up variation params in the fetcher. (Closed)

Patch Set: Add a comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/snippets_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/snippets_internals_message_handler.cc b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

index 8df849524ed6cb1f7ccee44cb8199bf41563dde7..e6187d4b6795b44c3b9367d48336fbc64242fab6 100644

--- a/chrome/browser/ui/webui/snippets_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

@@ -314,9 +314,6 @@ void SnippetsInternalsMessageHandler::SendAllContent() {

if (remote_suggestions_provider_) {

const ntp_snippets::RemoteSuggestionsFetcher* fetcher =

remote_suggestions_provider_->suggestions_fetcher_for_debugging();

- // TODO(fhorschig): Read this string from variations directly.

- SendString("switch-personalized", fetcher->PersonalizationModeString());

SendString("switch-fetch-url", fetcher->fetch_url().spec());

web_ui()->CallJavascriptFunctionUnsafe(

"chrome.SnippetsInternals.receiveJson",

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/ntp_snippets/remote/json_request.h » ('j') | no next file with comments »