Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: components/ntp_snippets/remote/json_request.cc

Issue 2665743002: [Remote suggestions] Clean up variation params in the fetcher. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/json_request.cc
diff --git a/components/ntp_snippets/remote/json_request.cc b/components/ntp_snippets/remote/json_request.cc
index 9c24b7f84955c89f41e2797715ef22fd5db96b7e..b085cc7ce3c4ad515a920bd6b5c0d5add0b55694 100644
--- a/components/ntp_snippets/remote/json_request.cc
+++ b/components/ntp_snippets/remote/json_request.cc
@@ -253,7 +253,6 @@ void JsonRequest::OnJsonError(const std::string& error) {
JsonRequest::Builder::Builder()
: fetch_api_(CHROME_READER_API),
- personalization_(Personalization::kBoth),
language_model_(nullptr) {}
JsonRequest::Builder::Builder(JsonRequest::Builder&&) = default;
JsonRequest::Builder::~Builder() = default;
@@ -307,12 +306,6 @@ JsonRequest::Builder& JsonRequest::Builder::SetParseJsonCallback(
return *this;
}
-JsonRequest::Builder& JsonRequest::Builder::SetPersonalization(
- Personalization personalization) {
- personalization_ = personalization;
- return *this;
-}
-
JsonRequest::Builder& JsonRequest::Builder::SetTickClock(
base::TickClock* tick_clock) {
tick_clock_ = tick_clock;
@@ -360,10 +353,6 @@ std::string JsonRequest::Builder::BuildBody() const {
std::string user_locale = PosixLocaleFromBCP47Language(params_.language_code);
switch (fetch_api_) {
case CHROME_READER_API: {
- auto content_params = base::MakeUnique<base::DictionaryValue>();
- content_params->SetBoolean("only_return_personalized_results",
- ReturnOnlyPersonalizedResults());
-
auto content_restricts = base::MakeUnique<base::ListValue>();
for (const auto* metadata : {"TITLE", "SNIPPET", "THUMBNAIL"}) {
auto entry = base::MakeUnique<base::DictionaryValue>();
@@ -373,7 +362,6 @@ std::string JsonRequest::Builder::BuildBody() const {
}
auto local_scoring_params = base::MakeUnique<base::DictionaryValue>();
- local_scoring_params->Set("content_params", std::move(content_params));
local_scoring_params->Set("content_restricts",
std::move(content_restricts));
@@ -436,7 +424,6 @@ std::string JsonRequest::Builder::BuildBody() const {
}
request->Set("topLanguages", std::move(language_list));
- // TODO(sfiera): Support only_return_personalized_results.
// TODO(sfiera): Support count_to_fetch.
break;
}

Powered by Google App Engine
This is Rietveld 408576698