Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: utils/kernel-service/kernel-service.dart

Issue 2665723002: Implement canonical name scheme in kernel. (Closed)
Patch Set: Address Kevin's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/kernel-service/kernel-service.dart
diff --git a/utils/kernel-service/kernel-service.dart b/utils/kernel-service/kernel-service.dart
index d162465e1d38c77aa5afe69334b48f42c2b83ac8..2247961726ea97bc6e2d14ec9c90c6a0414d583d 100644
--- a/utils/kernel-service/kernel-service.dart
+++ b/utils/kernel-service/kernel-service.dart
@@ -185,9 +185,10 @@ Future<CompilationResult> parseScriptImpl(DartLoaderBatch batch_loader,
packagePath: packageConfig,
customUriMappings: const {},
declaredVariables: const {});
+ program = new Program();
DartLoader loader =
- await batch_loader.getLoader(new Repository(), dartOptions);
- program = loader.loadProgram(fileName, target: target);
+ await batch_loader.getLoader(program, dartOptions);
+ loader.loadProgram(fileName, target: target);
if (loader.errors.isNotEmpty) {
return new CompilationError(loader.errors.toList(growable: false));
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698