pkg/kernel/lib/transformations/mixin_full_resolution.dart - Issue 2665723002: Implement canonical name scheme in kernel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/transformations/mixin_full_resolution.dart

Issue 2665723002: Implement canonical name scheme in kernel. (Closed)

Patch Set: Address Kevin's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/kernel/lib/transformations/mixin_full_resolution.dart

diff --git a/pkg/kernel/lib/transformations/mixin_full_resolution.dart b/pkg/kernel/lib/transformations/mixin_full_resolution.dart

index 8d8434778725ea30e098885f62af0cd7eeab1c74..7f200102ee61bad7ff5b1f5c87e14fb76f295ee1 100644

--- a/pkg/kernel/lib/transformations/mixin_full_resolution.dart

+++ b/pkg/kernel/lib/transformations/mixin_full_resolution.dart

@@ -115,7 +115,7 @@ class MixinFullResolution {

for (var superclassConstructor in class_.superclass.constructors) {

var forwardingConstructor =

buildForwardingConstructor(superclassCloner, superclassConstructor);

- class_.constructors.add(forwardingConstructor..parent = class_);

+ class_.addMember(forwardingConstructor);

}