Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: pkg/kernel/lib/clone.dart

Issue 2665723002: Implement canonical name scheme in kernel. (Closed)
Patch Set: Address Kevin's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/canonical_name.dart ('k') | pkg/kernel/lib/frontend/accessors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/clone.dart
diff --git a/pkg/kernel/lib/clone.dart b/pkg/kernel/lib/clone.dart
index 70b8d1042e076399e99ce3f20ac0b9b2d5012c1a..5a785556e81b9904409cc96a689ec93ba4d8a93f 100644
--- a/pkg/kernel/lib/clone.dart
+++ b/pkg/kernel/lib/clone.dart
@@ -68,63 +68,67 @@ class CloneVisitor extends TreeVisitor {
}
visitPropertyGet(PropertyGet node) {
- return new PropertyGet(
- clone(node.receiver), node.name, node.interfaceTarget);
+ return new PropertyGet.byReference(
+ clone(node.receiver), node.name, node.interfaceTargetReference);
}
visitPropertySet(PropertySet node) {
- return new PropertySet(clone(node.receiver), node.name, clone(node.value),
- node.interfaceTarget);
+ return new PropertySet.byReference(clone(node.receiver), node.name,
+ clone(node.value), node.interfaceTargetReference);
}
visitDirectPropertyGet(DirectPropertyGet node) {
- return new DirectPropertyGet(clone(node.receiver), node.target);
+ return new DirectPropertyGet.byReference(
+ clone(node.receiver), node.targetReference);
}
visitDirectPropertySet(DirectPropertySet node) {
- return new DirectPropertySet(
- clone(node.receiver), node.target, clone(node.value));
+ return new DirectPropertySet.byReference(
+ clone(node.receiver), node.targetReference, clone(node.value));
}
visitSuperPropertyGet(SuperPropertyGet node) {
- return new SuperPropertyGet(node.name, node.interfaceTarget);
+ return new SuperPropertyGet.byReference(
+ node.name, node.interfaceTargetReference);
}
visitSuperPropertySet(SuperPropertySet node) {
- return new SuperPropertySet(
- node.name, clone(node.value), node.interfaceTarget);
+ return new SuperPropertySet.byReference(
+ node.name, clone(node.value), node.interfaceTargetReference);
}
visitStaticGet(StaticGet node) {
- return new StaticGet(node.target);
+ return new StaticGet.byReference(node.targetReference);
}
visitStaticSet(StaticSet node) {
- return new StaticSet(node.target, clone(node.value));
+ return new StaticSet.byReference(node.targetReference, clone(node.value));
}
visitMethodInvocation(MethodInvocation node) {
- return new MethodInvocation(clone(node.receiver), node.name,
- clone(node.arguments), node.interfaceTarget);
+ return new MethodInvocation.byReference(clone(node.receiver), node.name,
+ clone(node.arguments), node.interfaceTargetReference);
}
visitDirectMethodInvocation(DirectMethodInvocation node) {
- return new DirectMethodInvocation(
- clone(node.receiver), node.target, clone(node.arguments));
+ return new DirectMethodInvocation.byReference(
+ clone(node.receiver), node.targetReference, clone(node.arguments));
}
visitSuperMethodInvocation(SuperMethodInvocation node) {
- return new SuperMethodInvocation(
- node.name, clone(node.arguments), node.interfaceTarget);
+ return new SuperMethodInvocation.byReference(
+ node.name, clone(node.arguments), node.interfaceTargetReference);
}
visitStaticInvocation(StaticInvocation node) {
- return new StaticInvocation(node.target, clone(node.arguments),
+ return new StaticInvocation.byReference(
+ node.targetReference, clone(node.arguments),
isConst: node.isConst);
}
visitConstructorInvocation(ConstructorInvocation node) {
- return new ConstructorInvocation(node.target, clone(node.arguments),
+ return new ConstructorInvocation.byReference(
+ node.targetReference, clone(node.arguments),
isConst: node.isConst);
}
« no previous file with comments | « pkg/kernel/lib/canonical_name.dart ('k') | pkg/kernel/lib/frontend/accessors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698