Implement canonical name scheme in kernel.

pkg/kernel/lib/analyzer/loader.dart

Index: pkg/kernel/lib/analyzer/loader.dart
diff --git a/pkg/kernel/lib/analyzer/loader.dart b/pkg/kernel/lib/analyzer/loader.dart
index d9dbf130209a83aa8396307babdb9012a0c8f8fc..62879499e69b04ec0b72fc0c20d0492096d51788 100644
--- a/pkg/kernel/lib/analyzer/loader.dart
+++ b/pkg/kernel/lib/analyzer/loader.dart
@@ -22,7 +22,6 @@ import 'package:package_config/discovery.dart';
 import 'package:package_config/packages.dart';
 
 import '../ast.dart' as ast;
-import '../repository.dart';
 import '../target/targets.dart' show Target;
 import '../type_algebra.dart';
 import 'analyzer.dart';
@@ -88,7 +87,7 @@ abstract class ReferenceLevelLoader {
 }
 
 class DartLoader implements ReferenceLevelLoader {
-  final Repository repository;
+  final ast.Program program;
   final ApplicationRoot applicationRoot;
   final Bimap<ClassElement, ast.Class> _classes =
       new Bimap<ClassElement, ast.Class>();
@@ -97,6 +96,8 @@ class DartLoader implements ReferenceLevelLoader {
       <TypeParameterElement, ast.TypeParameter>{};
   final Map<ast.Library, Map<String, ast.Class>> _mixinApplications =
       <ast.Library, Map<String, ast.Class>>{};
+  final Map<LibraryElement, ast.Library> _libraries =
+      <LibraryElement, ast.Library>{};
   final AnalysisContext context;
   LibraryElement _dartCoreLibrary;
   final List errors = [];
@@ -114,7 +115,7 @@ class DartLoader implements ReferenceLevelLoader {
 
   bool get strongMode => context.analysisOptions.strongMode;
 
-  DartLoader(this.repository, DartOptions options, Packages packages,
+  DartLoader(this.program, DartOptions options, Packages packages,
       {DartSdk dartSdk,
       AnalysisContext context,
       this.ignoreRedirectingFactories: true})
@@ -126,11 +127,28 @@ class DartLoader implements ReferenceLevelLoader {
     return element.name.isEmpty ? null : element.name;
   }
 
+  LibraryElement getLibraryElementFromUri(Uri uri) {
+    var source = context.sourceFactory.forUri2(uri);
+    if (source == null) return null;
+    return context.computeLibraryElement(source);
+  }
+
   ast.Library getLibraryReference(LibraryElement element) {
     var uri = applicationRoot.relativeUri(element.source.uri);
-    return repository.getLibraryReference(uri)
-      ..name ??= getLibraryName(element)
-      ..fileUri = '${element.source.uri}';
+    var library = _libraries[element];
+    if (library == null) {
+      library = new ast.Library(uri)
+          ..isExternal = true
+          ..name = getLibraryName(element)
+          ..fileUri = '${element.source.uri}';
+      program.libraries.add(library..parent = program);
+      _libraries[element] = library;
+    }
+    return library;
+  }
+
+  ast.Library getLibraryReferenceFromUri(Uri uri) {
+    return getLibraryReference(getLibraryElementFromUri(uri));
   }
 
   void _buildTopLevelMember(
@@ -348,9 +366,9 @@ class DartLoader implements ReferenceLevelLoader {
               mixedInType: freshParameters.substituteSuper(mixinType),
               fileUri: classNode.fileUri)..fileOffset = element.nameOffset;
           mixinClass.level = ast.ClassLevel.Type;
+          addMixinClassToLibrary(mixinClass, classNode.enclosingLibrary);
           supertype = new ast.Supertype(mixinClass,
               classNode.typeParameters.map(makeTypeParameterType).toList());
-          addMixinClassToLibrary(mixinClass, classNode.enclosingLibrary);
           // This class cannot be used from anywhere else, so don't try to
           // generate shared mixin applications using it.
           useSharedMixin = false;
@@ -446,25 +464,25 @@ class DartLoader implements ReferenceLevelLoader {
 
   ast.Member _buildMemberReference(Element element) {
     assert(element != null);
-    var node = _buildOrphanedMemberReference(element);
+    var member = _buildOrphanedMemberReference(element);
     // Set the parent pointer and store it in the enclosing class or library.
     // If the enclosing library is being built from the AST, do not add the
     // member, since the AST builder will put it in there.
     var parent = element.enclosingElement;
     if (parent is ClassElement) {
       var class_ = getClassReference(parent);
-      node.parent = class_;
+      member.parent = class_;
       if (!isLibraryBeingLoaded(element.library)) {
-        class_.addMember(node);
+        class_.addMember(member);
       }
     } else {
       var library = getLibraryReference(element.library);
-      node.parent = library;
+      member.parent = library;
       if (!isLibraryBeingLoaded(element.library)) {
-        library.addMember(node);
+        library.addMember(member);
       }
     }
-    return node;
+    return member;
   }
 
   ast.Member _buildOrphanedMemberReference(Element element) {
@@ -717,8 +735,8 @@ class DartLoader implements ReferenceLevelLoader {
         }
       }
     }
-    for (int i = 0; i < repository.libraries.length; ++i) {
-      var library = repository.libraries[i];
+    for (int i = 0; i < program.libraries.length; ++i) {
+      var library = program.libraries[i];
       if (compileSdk || library.importUri.scheme != 'dart') {
         ensureLibraryIsLoaded(library);
       }
@@ -730,7 +748,7 @@ class DartLoader implements ReferenceLevelLoader {
   /// This operation may be expensive and should only be used for diagnostics.
   List<String> getLoadedFileNames() {
     var list = <String>[];
-    for (var library in repository.libraries) {
+    for (var library in program.libraries) {
       LibraryElement element = context.computeLibraryElement(context
           .sourceFactory
           .forUri2(applicationRoot.absoluteUri(library.importUri)));
@@ -789,12 +807,10 @@ class DartLoader implements ReferenceLevelLoader {
   }
 
   ast.Program loadProgram(Uri mainLibrary, {Target target, bool compileSdk}) {

[Kevin Millikin (Google), 2017/02/22 09:09:30]

It's a little weird that this mutates the loader's program and also returns it. 
I think it makes the call sites slightly misleading.  Recommend making it return
void.

[asgerf, 2017/02/22 10:06:54]

Done.

-    Uri uri = applicationRoot.relativeUri(mainLibrary);
-    ast.Library library = repository.getLibraryReference(uri);
+    ast.Library library = getLibraryReferenceFromUri(mainLibrary);
     ensureLibraryIsLoaded(library);
     var mainMethod = _getMainMethod(mainLibrary);
     loadEverything(target: target, compileSdk: compileSdk);
-    var program = new ast.Program(repository.libraries);
     if (mainMethod == null) {
       mainMethod = _makeMissingMainMethod(library);
     }
@@ -819,8 +835,7 @@ class DartLoader implements ReferenceLevelLoader {
   }
 
   ast.Library loadLibrary(Uri uri) {
-    ast.Library library =
-        repository.getLibraryReference(applicationRoot.relativeUri(uri));
+    ast.Library library = getLibraryReferenceFromUri(uri);
     ensureLibraryIsLoaded(library);
     return library;
   }
@@ -851,7 +866,7 @@ class DartLoaderBatch {
   String lastPackagePath;
   bool lastStrongMode;
 
-  Future<DartLoader> getLoader(Repository repository, DartOptions options,
+  Future<DartLoader> getLoader(ast.Program program, DartOptions options,
       {String packageDiscoveryPath}) async {
     if (dartSdk == null ||
         lastSdk != options.sdk ||
@@ -867,7 +882,7 @@ class DartLoaderBatch {
       packages = await createPackages(options.packagePath,
           discoveryPath: packageDiscoveryPath);
     }
-    return new DartLoader(repository, options, packages, dartSdk: dartSdk);
+    return new DartLoader(program, options, packages, dartSdk: dartSdk);
   }
 }