Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: pkg/kernel/lib/clone.dart

Issue 2665723002: Implement canonical name scheme in kernel. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/clone.dart
diff --git a/pkg/kernel/lib/clone.dart b/pkg/kernel/lib/clone.dart
index 3b9a6a20947d457133ab57ea865237d731b0f1b5..236de599ec5a4abf556a45053cafca56cc4b7807 100644
--- a/pkg/kernel/lib/clone.dart
+++ b/pkg/kernel/lib/clone.dart
@@ -68,62 +68,63 @@ class CloneVisitor extends TreeVisitor {
}
visitPropertyGet(PropertyGet node) {
- return new PropertyGet(
- clone(node.receiver), node.name, node.interfaceTarget);
+ return new PropertyGet.byName(
+ clone(node.receiver), node.name, node.interfaceTargetName);
}
visitPropertySet(PropertySet node) {
- return new PropertySet(clone(node.receiver), node.name, clone(node.value),
- node.interfaceTarget);
+ return new PropertySet.byName(clone(node.receiver), node.name,
+ clone(node.value), node.interfaceTargetName);
}
visitDirectPropertyGet(DirectPropertyGet node) {
- return new DirectPropertyGet(clone(node.receiver), node.target);
+ return new DirectPropertyGet.byName(clone(node.receiver), node.targetName);
}
visitDirectPropertySet(DirectPropertySet node) {
- return new DirectPropertySet(
- clone(node.receiver), node.target, clone(node.value));
+ return new DirectPropertySet.byName(
+ clone(node.receiver), node.targetName, clone(node.value));
}
visitSuperPropertyGet(SuperPropertyGet node) {
- return new SuperPropertyGet(node.name, node.interfaceTarget);
+ return new SuperPropertyGet.byName(node.name, node.interfaceTargetName);
}
visitSuperPropertySet(SuperPropertySet node) {
- return new SuperPropertySet(
- node.name, clone(node.value), node.interfaceTarget);
+ return new SuperPropertySet.byName(
+ node.name, clone(node.value), node.interfaceTargetName);
}
visitStaticGet(StaticGet node) {
- return new StaticGet(node.target);
+ return new StaticGet.byName(node.targetName);
}
visitStaticSet(StaticSet node) {
- return new StaticSet(node.target, clone(node.value));
+ return new StaticSet.byName(node.targetName, clone(node.value));
}
visitMethodInvocation(MethodInvocation node) {
- return new MethodInvocation(clone(node.receiver), node.name,
- clone(node.arguments), node.interfaceTarget);
+ return new MethodInvocation.byName(clone(node.receiver), node.name,
+ clone(node.arguments), node.interfaceTargetName);
}
visitDirectMethodInvocation(DirectMethodInvocation node) {
- return new DirectMethodInvocation(
- clone(node.receiver), node.target, clone(node.arguments));
+ return new DirectMethodInvocation.byName(
+ clone(node.receiver), node.targetName, clone(node.arguments));
}
visitSuperMethodInvocation(SuperMethodInvocation node) {
- return new SuperMethodInvocation(
- node.name, clone(node.arguments), node.interfaceTarget);
+ return new SuperMethodInvocation.byName(
+ node.name, clone(node.arguments), node.interfaceTargetName);
}
visitStaticInvocation(StaticInvocation node) {
- return new StaticInvocation(node.target, clone(node.arguments));
+ return new StaticInvocation.byName(node.targetName, clone(node.arguments));
}
visitConstructorInvocation(ConstructorInvocation node) {
- return new ConstructorInvocation(node.target, clone(node.arguments));
+ return new ConstructorInvocation.byName(
+ node.targetName, clone(node.arguments));
}
visitNot(Not node) {

Powered by Google App Engine
This is Rietveld 408576698