Implement canonical name scheme in kernel.

pkg/kernel/lib/verifier.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library kernel.checks;
 
 import 'ast.dart';
 import 'transformations/flags.dart';
 
 void verifyProgram(Program program) {
   VerifyingVisitor.check(program);
@@ skipping 13 matching lines @@
     try {
       location = node?.location ?? context?.location;
     } catch (_) {
       // TODO(ahe): Fix the compiler instead.
     }
     if (location != null) {
       String file = location.file ?? "";
       return "$file:${location.line}:${location.column}: Verification error:"
           " $details";
     } else {
-      return
-          "Verification error: $details\nContext: '$context'.\nNode: '$node'.";
+      return "Verification error: $details\nContext: '$context'.\nNode: '$node'.";
     }
   }
 }
 
 /// Checks that a kernel program is well-formed.
 ///
 /// This does not include any kind of type checking.
 class VerifyingVisitor extends RecursiveVisitor {
   final Set<Class> classes = new Set<Class>();
   final Set<TypeParameter> typeParameters = new Set<TypeParameter>();
@@ skipping 17 matching lines @@
   defaultTreeNode(TreeNode node) {
     visitChildren(node);
   }
 
   problem(TreeNode node, String details) {
     throw new VerificationError(context, node, details);
   }
 
   TreeNode enterParent(TreeNode node) {
     if (!identical(node.parent, currentParent)) {
-      problem(node,
+      problem(
+          node,
           "Incorrect parent pointer: expected '${node.parent.runtimeType}',"
           " but found: '${currentParent.runtimeType}'.");
     }
     var oldParent = currentParent;
     currentParent = node;
     return oldParent;
   }
 
   void exitParent(TreeNode oldParent) {
     currentParent = oldParent;
@@ skipping 233 matching lines @@
   }
 
   @override
   visitStaticInvocation(StaticInvocation node) {
     checkTargetedInvocation(node.target, node);
     if (node.target.isInstanceMember) {
       problem(node,
           "StaticInvocation of '${node.target}' that's an instance member.");
     }
     if (node.isConst &&
-        (!node.target.isConst || !node.target.isExternal ||
+        (!node.target.isConst ||
+            !node.target.isExternal ||
             node.target.kind != ProcedureKind.Factory)) {
-      problem(node, "Constant StaticInvocation of '${node.target}' that isn't"
+      problem(
+          node,
+          "Constant StaticInvocation of '${node.target}' that isn't"
           " a const external factory.");
     }
   }
 
   void checkTargetedInvocation(Member target, InvocationExpression node) {
     visitChildren(node);
     if (target == null) {
       problem(node, "${node.runtimeType} without target.");
     }
     if (target.function == null) {
       problem(node, "${node.runtimeType} without function.");
     }
     if (!areArgumentsCompatible(node.arguments, target.function)) {
       problem(node,
           "${node.runtimeType} with incompatible arguments for '${target}'.");
     }
     int expectedTypeParameters = target is Constructor
         ? target.enclosingClass.typeParameters.length
         : target.function.typeParameters.length;
     if (node.arguments.types.length != expectedTypeParameters) {
-      problem(node, "${node.runtimeType} with wrong number of type arguments"
+      problem(
+          node,
+          "${node.runtimeType} with wrong number of type arguments"
           " for '${target}'.");
     }
   }
 
   @override
   visitDirectPropertyGet(DirectPropertyGet node) {
     visitChildren(node);
     if (node.target == null) {
       problem(node, "DirectPropertyGet without target.");
     }
     if (!node.target.hasGetter) {
       problem(node, "DirectPropertyGet of '${node.target}' without getter.");
     }
     if (!node.target.isInstanceMember) {
-      problem(node, "DirectPropertyGet of '${node.target}' that isn't an"
+      problem(
+          node,
+          "DirectPropertyGet of '${node.target}' that isn't an"
           " instance member.");
     }
   }
 
   @override
   visitDirectPropertySet(DirectPropertySet node) {
     visitChildren(node);
     if (node.target == null) {
       problem(node, "DirectPropertySet without target.");
     }
@@ skipping 13 matching lines @@
     }
   }
 
   @override
   visitConstructorInvocation(ConstructorInvocation node) {
     checkTargetedInvocation(node.target, node);
     if (node.target.enclosingClass.isAbstract) {
       problem(node, "ConstructorInvocation of abstract class.");
     }
     if (node.isConst && !node.target.isConst) {
-      problem(node, "Constant ConstructorInvocation fo '${node.target}' that"
+      problem(
+          node,
+          "Constant ConstructorInvocation fo '${node.target}' that"
           " isn't const.");
     }
   }
 
   bool areArgumentsCompatible(Arguments arguments, FunctionNode function) {
     if (arguments.positional.length < function.requiredParameterCount) {
       return false;
     }
     if (arguments.positional.length > function.positionalParameters.length) {
       return false;
     }
     namedLoop:
     for (int i = 0; i < arguments.named.length; ++i) {
       var argument = arguments.named[i];
       String name = argument.name;
       for (int j = 0; j < function.namedParameters.length; ++j) {
         if (function.namedParameters[j].name == name) continue namedLoop;
       }
       return false;
     }
     return true;
   }
 
   @override
   defaultMemberReference(Member node) {
     if (node.transformerFlags & TransformerFlag.seenByVerifier == 0) {
-      problem(node,
-          "Dangling reference to '$node', parent is: '${node.parent}'.");
+      problem(
+          node, "Dangling reference to '$node', parent is: '${node.parent}'.");
     }
   }
 
   @override
   visitClassReference(Class node) {
     if (!classes.contains(node)) {
-      problem(node,
-          "Dangling reference to '$node', parent is: '${node.parent}'.");
+      problem(
+          node, "Dangling reference to '$node', parent is: '${node.parent}'.");
     }
   }
 
   @override
   visitTypeParameterType(TypeParameterType node) {
     var parameter = node.parameter;
     if (!typeParameters.contains(parameter)) {
-      problem(currentParent, "Type parameter '$parameter' referenced out of"
+      problem(
+          currentParent,
+          "Type parameter '$parameter' referenced out of"
           " scope, parent is: '${parameter.parent}'.");
     }
     if (parameter.parent is Class && !classTypeParametersAreInScope) {
-      problem(currentParent, "Type parameter '$parameter' referenced from"
+      problem(
+          currentParent,
+          "Type parameter '$parameter' referenced from"
           " static context, parent is '${parameter.parent}'.");
     }
   }
 
   @override
   visitInterfaceType(InterfaceType node) {
     node.visitChildren(this);
     if (node.typeArguments.length != node.classNode.typeParameters.length) {
-      problem(currentParent, "Type $node provides ${node.typeArguments.length}"
+      problem(
+          currentParent,
+          "Type $node provides ${node.typeArguments.length}"
           " type arguments but the class declares"
           " ${node.classNode.typeParameters.length} parameters.");
     }
   }
 }
 
 class CheckParentPointers extends Visitor {
   static void check(TreeNode node) {
     node.accept(new CheckParentPointers(node.parent));
   }
 
   TreeNode parent;
 
   CheckParentPointers([this.parent]);
 
   defaultTreeNode(TreeNode node) {
     if (node.parent != parent) {
-      throw new VerificationError(parent, node,
+      throw new VerificationError(
+          parent,
+          node,
           "Parent pointer on '${node.runtimeType}' "
           "is '${node.parent.runtimeType}' "
           "but should be '${parent.runtimeType}'.");
     }
     var oldParent = parent;
     parent = node;
     node.visitChildren(this);
     parent = oldParent;
   }
 }
 
 void checkInitializers(Constructor constructor) {
   // TODO(ahe): I'll add more here in other CLs.
 }