Implement canonical name scheme in kernel.

pkg/kernel/lib/verifier.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library kernel.checks;
 
 import 'ast.dart';
 import 'transformations/flags.dart';
 
 void verifyProgram(Program program) {
   VerifyingVisitor.check(program);
@@ skipping 154 matching lines @@
       for (var library in program.libraries) {
         library.members.forEach(undeclareMember);
         for (var class_ in library.classes) {
           class_.members.forEach(undeclareMember);
         }
       }
       variableStack.forEach(undeclareVariable);
     }
   }
 
+  void checkCanonicalName(CanonicalName name, LinkedNode definition) {

[Kevin Millikin (Google), 2017/02/22 09:09:30]

Get rid of the function?  Or if we sometimes want it, pass a flag to the verify
to tell it to check?

[asgerf, 2017/02/22 10:06:54]

Removed the function. I did not intend to upload the outcommented version.

+    // if (name == null) {
+    //   throw '$definition has no canonical name';
+    // }
+    // if (name.box.node != definition) {
+    //   throw '$definition has name $name, but that is bound to '
+    //       '${name.box.node}';
+    // }
+  }
+
   visitField(Field node) {
+    checkCanonicalName(node.canonicalName, node);
     currentMember = node;
     var oldParent = enterParent(node);
     classTypeParametersAreInScope = !node.isStatic;
     node.initializer?.accept(this);
     classTypeParametersAreInScope = false;
     visitList(node.annotations, this);
     exitParent(oldParent);
     currentMember = null;
   }
 
   visitProcedure(Procedure node) {
+    checkCanonicalName(node.canonicalName, node);
     currentMember = node;
     var oldParent = enterParent(node);
     classTypeParametersAreInScope = !node.isStatic;
     node.function.accept(this);
     classTypeParametersAreInScope = false;
     visitList(node.annotations, this);
     exitParent(oldParent);
     currentMember = null;
   }
 
   visitConstructor(Constructor node) {
+    checkCanonicalName(node.canonicalName, node);
     currentMember = node;
     classTypeParametersAreInScope = true;
     // The constructor member needs special treatment due to parameters being
     // in scope in the initializer list.
     var oldParent = enterParent(node);
     int stackHeight = enterLocalScope();
     visitChildren(node.function);
     visitList(node.initializers, this);
     if (!isOutline) {
       checkInitializers(node);
     }
     exitLocalScope(stackHeight);
     classTypeParametersAreInScope = false;
     visitList(node.annotations, this);
     exitParent(oldParent);
     classTypeParametersAreInScope = false;
     currentMember = null;
   }
 
   visitClass(Class node) {
+    checkCanonicalName(node.canonicalName, node);
     currentClass = node;
     declareTypeParameters(node.typeParameters);
     var oldParent = enterParent(node);
     classTypeParametersAreInScope = false;
     visitList(node.annotations, this);
     classTypeParametersAreInScope = true;
     visitList(node.typeParameters, this);
     visitList(node.fields, this);
     visitList(node.constructors, this);
     visitList(node.procedures, this);
@@ skipping 251 matching lines @@
     var oldParent = parent;
     parent = node;
     node.visitChildren(this);
     parent = oldParent;
   }
 }
 
 void checkInitializers(Constructor constructor) {
   // TODO(ahe): I'll add more here in other CLs.
 }