Fix Jumplist favicons to have high resolution in HDPI Windows displays

ui/gfx/image/image_skia.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_IMAGE_IMAGE_SKIA_H_
 #define UI_GFX_IMAGE_IMAGE_SKIA_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 85 matching lines @@
   bool BackedBySameObjectAs(const gfx::ImageSkia& other) const;
 
   // Adds |image_rep| to the image reps contained by this object.
   void AddRepresentation(const gfx::ImageSkiaRep& image_rep);
 
   // Removes the image rep of |scale| if present.
   void RemoveRepresentation(float scale);
 
   // Returns true if the object owns an image rep whose density matches
   // |scale| exactly.
   bool HasRepresentation(float scale) const;

[sky, 2017/02/02 22:41:16]

Can't you use HasRepresentation and GetRepresentation?

[chengx, 2017/02/03 01:51:13]

HasRepresentation() doesn't work here as it calls
storage_->FindRepresentation(scale, false) with the 2nd parameter set to "false"
within itself. As a result, it always returns false which makes it useless. I
use GetRepresentation() only, which works. See the new patch uploaded please.

 
   // Returns the image rep whose density best matches |scale|.
   // Returns a null image rep if the object contains no image reps.
   const gfx::ImageSkiaRep& GetRepresentation(float scale) const;
 
   // Make the ImageSkia instance read-only. Note that this only prevent
   // modification from client code, and the storage may still be
   // modified by the source if any (thus, it's not thread safe).  This
   // detaches the storage from currently accessing thread, so its safe
   // to pass it to other thread as long as it is accessed only by that
@@ skipping 16 matching lines @@
   int height() const;
   gfx::Size size() const;
 
   // Returns pointer to 1x bitmap contained by this object. If there is no 1x
   // bitmap, the bitmap whose scale factor is closest to 1x is returned.
   // This function should only be used in unittests and on platforms which do
   // not support scale factors other than 1x.
   // TODO(pkotwicz): Return null SkBitmap when the object has no 1x bitmap.
   const SkBitmap* bitmap() const { return &GetBitmap(); }
 
+  // Returns pointer to 2x bitmap contained by this object. If there is no 2x
+  // bitmap, the bitmap whose scale factor is closest to 2x is returned.
+  const SkBitmap* bitmap2x() const { return &GetBitmap2x(); }
+
   // Returns a vector with the image reps contained in this object.
   // There is no guarantee that this will return all images rep for
   // supported scale factors.
   std::vector<gfx::ImageSkiaRep> image_reps() const;
 
   // When the source is available, generates all ImageReps for
   // supported scale factors. This method is defined as const as
   // the state change in the storage is agnostic to the caller.
   void EnsureRepsForSupportedScales() const;
 
  private:
   friend class test::TestOnThread;
   FRIEND_TEST_ALL_PREFIXES(ImageSkiaTest, EmptyOnThreadTest);
   FRIEND_TEST_ALL_PREFIXES(ImageSkiaTest, StaticOnThreadTest);
   FRIEND_TEST_ALL_PREFIXES(ImageSkiaTest, SourceOnThreadTest);
 
   // Initialize ImageSkiaStorage with passed in parameters.
   // If the image rep's bitmap is empty, ImageStorage is set to NULL.
   void Init(const gfx::ImageSkiaRep& image_rep);
 
   const SkBitmap& GetBitmap() const;
+  const SkBitmap& GetBitmap2x() const;
 
   // Checks if the current thread can read/modify the ImageSkia.
   bool CanRead() const;
   bool CanModify() const;
 
   // Detach the storage from the currently assinged thread
   // so that other thread can access the storage.
   void DetachStorageFromThread();
 
   // A refptr so that ImageRepSkia can be copied cheaply.
   scoped_refptr<internal::ImageSkiaStorage> storage_;
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_IMAGE_IMAGE_SKIA_H_