Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3136)

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 266553002: Add TrackedPreferenceValidationDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix expectations for android and cros Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/chrome_pref_service_factory.cc
diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc
index 8c6689acf98dca1250f5cd9de60e3727bd61bcb7..5f699aedade76a11ffbce10ed4eb387cf9ae892e 100644
--- a/chrome/browser/prefs/chrome_pref_service_factory.cc
+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc
@@ -31,6 +31,7 @@
#include "chrome/browser/prefs/pref_service_syncable.h"
#include "chrome/browser/prefs/pref_service_syncable_factory.h"
#include "chrome/browser/prefs/profile_pref_store_manager.h"
+#include "chrome/browser/prefs/tracked/tracked_preference_validation_observer.h"
#include "chrome/browser/profiles/file_path_verifier_win.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -424,14 +425,16 @@ scoped_ptr<PrefServiceSyncable> CreateProfilePrefs(
bool async) {
TRACE_EVENT0("browser", "chrome_prefs::CreateProfilePrefs");
PrefServiceSyncableFactory factory;
- PrepareFactory(&factory,
- policy_service,
- managed_user_settings,
- scoped_refptr<PersistentPrefStore>(
- CreateProfilePrefStoreManager(profile_path)
- ->CreateProfilePrefStore(pref_io_task_runner)),
- extension_prefs,
- async);
+ PrepareFactory(
+ &factory,
+ policy_service,
+ managed_user_settings,
+ scoped_refptr<PersistentPrefStore>(
+ CreateProfilePrefStoreManager(profile_path)->CreateProfilePrefStore(
+ pref_io_task_runner,
+ scoped_ptr<TrackedPreferenceValidationObserver>())),
erikwright (departed) 2014/05/14 00:39:26 I gather the actual implementation will be supplie
grt (UTC plus 2) 2014/05/14 18:57:22 Correct.
+ extension_prefs,
+ async);
scoped_ptr<PrefServiceSyncable> pref_service =
factory.CreateSyncable(pref_registry.get());
« no previous file with comments | « no previous file | chrome/browser/prefs/mock_validation_observer.h » ('j') | chrome/browser/prefs/mock_validation_observer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698