Add TrackedPreferenceValidationDelegate

chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h

Index: chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h
diff --git a/chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h b/chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..64a6cc4371d7f273dcb4703849043b48ec9ead8a
--- /dev/null
+++ b/chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_VALIDATION_DELEGATE_H_
+#define CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_VALIDATION_DELEGATE_H_
+
+#include <string>
+#include <vector>
+
+#include "chrome/browser/prefs/pref_hash_store_transaction.h"
+#include "chrome/browser/prefs/tracked/tracked_preference_helper.h"
+
+namespace base {
+class DictionaryValue;
+class Value;
+}
+
+// A TrackedPreferenceValidationDelegate is notified of the results of each
+// tracked preference validation event.
+class TrackedPreferenceValidationDelegate {
+ public:
+  virtual ~TrackedPreferenceValidationDelegate() {}
+
+  // Notifies observes of the result (|value_state|) of checking the atomic

[gab, 2014/06/10 16:22:09]

s/observes/observers ?

+  // |value| at |pref_path|. |reset_action| indicates whether or not a reset
+  // will occur based on |value_state| and the enforcement level in place.
+  virtual void OnAtomicPreferenceValidation(
+      const std::string& pref_path,
+      const base::Value* value,
+      PrefHashStoreTransaction::ValueState value_state,
+      TrackedPreferenceHelper::ResetAction reset_action) = 0;
+
+  // Notifies observes of the result (|value_state|) of checking the split

[gab, 2014/06/10 16:22:09]

s/observes/observers

+  // |dict_value| at |pref_path|. |reset_action| indicates whether or not a
+  // reset of |value_keys| will occur based on |value_state| and the enforcement
+  // level in place.
+  virtual void OnSplitPreferenceValidation(
+      const std::string& pref_path,
+      const base::DictionaryValue* dict_value,
+      const std::vector<std::string>& invalid_keys,
+      PrefHashStoreTransaction::ValueState value_state,
+      TrackedPreferenceHelper::ResetAction reset_action) = 0;

[gab, 2014/06/10 16:22:08]

Why would you need to track atomic/split preferences differently?

I'd think the only thing an observer would care about is the |pref_path|,
|value_state|, and |reset_action|.

Why would it need the atomic/split strategy, the |value| and the |invalid_keys|?

At least the current mock tests don't really test |value| and |invalid_keys|
(they do test strategy for the sake of coverage, but don't otherwise indicate a
reason for reporting both differently).

+};
+
+#endif  // CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_VALIDATION_DELEGATE_H_