Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: chrome/browser/prefs/tracked/tracked_split_preference.h

Issue 266553002: Add TrackedPreferenceValidationDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mnissler nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/tracked_split_preference.h
diff --git a/chrome/browser/prefs/tracked/tracked_split_preference.h b/chrome/browser/prefs/tracked/tracked_split_preference.h
index df0c59c17693f43b3b9ebc7b1565690c36e02904..1892c73eb015d601963e9814bb286d2a0e7c9cf1 100644
--- a/chrome/browser/prefs/tracked/tracked_split_preference.h
+++ b/chrome/browser/prefs/tracked/tracked_split_preference.h
@@ -13,18 +13,21 @@
#include "chrome/browser/prefs/tracked/tracked_preference.h"
#include "chrome/browser/prefs/tracked/tracked_preference_helper.h"
+class TrackedPreferenceValidationDelegate;
+
// A TrackedSplitPreference must be tracking a dictionary pref. Each top-level
-// entry in its dictionary is tracked and enforced independently.
+// entry in its dictionary is tracked and enforced independently. An optional
+// delegate is notified of the status of the preference during enforcement.
// Note: preferences using this strategy must be kept in sync with
// TrackedSplitPreferences in histograms.xml.
class TrackedSplitPreference : public TrackedPreference {
public:
// Constructs a TrackedSplitPreference. |pref_path| must be a dictionary pref.
- TrackedSplitPreference(
- const std::string& pref_path,
- size_t reporting_id,
- size_t reporting_ids_count,
- PrefHashFilter::EnforcementLevel enforcement_level);
+ TrackedSplitPreference(const std::string& pref_path,
+ size_t reporting_id,
+ size_t reporting_ids_count,
+ PrefHashFilter::EnforcementLevel enforcement_level,
+ TrackedPreferenceValidationDelegate* delegate);
// TrackedPreference implementation.
virtual void OnNewValue(const base::Value* value,
@@ -36,6 +39,7 @@ class TrackedSplitPreference : public TrackedPreference {
private:
const std::string pref_path_;
const TrackedPreferenceHelper helper_;
+ TrackedPreferenceValidationDelegate* delegate_;
DISALLOW_COPY_AND_ASSIGN(TrackedSplitPreference);
};

Powered by Google App Engine
This is Rietveld 408576698