Add TrackedPreferenceValidationDelegate

chrome/browser/prefs/mock_validation_observer.h

Index: chrome/browser/prefs/mock_validation_observer.h
diff --git a/chrome/browser/prefs/mock_validation_observer.h b/chrome/browser/prefs/mock_validation_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..edcba4f83d57e22a2d34a5e332e3c6fae623b2fb
--- /dev/null
+++ b/chrome/browser/prefs/mock_validation_observer.h
@@ -0,0 +1,91 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_MOCK_VALIDATION_OBSERVER_H_
+#define CHROME_BROWSER_PREFS_MOCK_VALIDATION_OBSERVER_H_
+
+#include <string>
+#include <vector>
+
+#include "base/compiler_specific.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/prefs/pref_hash_filter.h"
+#include "chrome/browser/prefs/pref_hash_store_transaction.h"
+#include "chrome/browser/prefs/tracked/tracked_preference_helper.h"
+#include "chrome/browser/prefs/tracked/tracked_preference_validation_observer.h"
+
+// A mock tracked preference validation observer for use by tests.
+class MockValidationObserver : public TrackedPreferenceValidationObserver {
+ public:
+  // A container of observed validation events.
+  class ValidationData : public base::RefCounted<ValidationData> {

[Mattias Nissler (ping if slow), 2014/05/15 14:32:25]

Is there a good reason to split the observer implementation and the validation
data container into two different classes?

[grt (UTC plus 2), 2014/05/15 18:21:35]

This is a consequence of the decision to have ownership of the observer
transferred to the PersistentPrefStore. The data may need to be accessed in the
test after the observer has been destroyed. Erik has suggested a simplification
to this split that I'm happy to implement if you feel it's important.

+   public:
+    struct ValidationEvent {
+      ValidationEvent(const std::string& path,
+                      PrefHashStoreTransaction::ValueState state,
+                      TrackedPreferenceHelper::ResetAction action,
+                      PrefHashFilter::PrefTrackingStrategy tracking_strategy)
+          : pref_path(path),
+            value_state(state),
+            reset_action(action),
+            strategy(tracking_strategy) {}
+
+      std::string pref_path;
+      PrefHashStoreTransaction::ValueState value_state;
+      TrackedPreferenceHelper::ResetAction reset_action;
+      PrefHashFilter::PrefTrackingStrategy strategy;
+    };
+    ValidationData();
+
+    // Adds a new validation event.
+    void RecordValidation(const std::string& pref_path,
+                          PrefHashStoreTransaction::ValueState value_state,
+                          TrackedPreferenceHelper::ResetAction reset_action,
+                          PrefHashFilter::PrefTrackingStrategy strategy);
+
+    // Returns the number of recorded validations.
+    size_t recorded_validations_count() const { return validations_.size(); }
+
+    // Returns the number of validations of a given value state.
+    size_t CountValidationsOfState(
+        PrefHashStoreTransaction::ValueState value_state) const;
+
+    // Returns the event for the preference with a given path.
+    const ValidationEvent* GetEventForPath(const std::string& pref_path) const;
+
+    // Returns all recorded validation.
+    void GetAllEvents(std::vector<ValidationEvent>* validations) const;
+
+   private:
+    friend class base::RefCounted<ValidationData>;
+    ~ValidationData();
+
+    std::vector<ValidationEvent> validations_;
+    DISALLOW_COPY_AND_ASSIGN(ValidationData);
+  };
+
+  explicit MockValidationObserver(
+      const scoped_refptr<ValidationData>& validation_data);
+  virtual ~MockValidationObserver();
+
+  // TrackedPreferenceValidationObserver implementation.
+  virtual void OnAtomicPreferenceValidation(
+      const std::string& pref_path,
+      const base::Value* value,
+      PrefHashStoreTransaction::ValueState value_state,
+      TrackedPreferenceHelper::ResetAction reset_action) OVERRIDE;
+  virtual void OnSplitPreferenceValidation(
+      const std::string& pref_path,
+      const base::DictionaryValue* dict_value,
+      const std::vector<std::string>& invalid_keys,
+      PrefHashStoreTransaction::ValueState value_state,
+      TrackedPreferenceHelper::ResetAction reset_action) OVERRIDE;
+
+ private:
+  scoped_refptr<ValidationData> validation_data_;
+  DISALLOW_COPY_AND_ASSIGN(MockValidationObserver);
+};
+
+#endif  // CHROME_BROWSER_PREFS_MOCK_VALIDATION_OBSERVER_H_