Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Side by Side Diff: chrome/browser/prefs/tracked/tracked_preference.h

Issue 266553002: Add TrackedPreferenceValidationDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix expectations for android and cros Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_H_ 5 #ifndef CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_H_
6 #define CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_H_ 6 #define CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_H_
7 7
8 class PrefHashStoreTransaction; 8 class PrefHashStoreTransaction;
9 class TrackedPreferenceValidationObserver;
9 10
10 namespace base { 11 namespace base {
11 class DictionaryValue; 12 class DictionaryValue;
12 class Value; 13 class Value;
13 } 14 }
14 15
15 // A TrackedPreference tracks changes to an individual preference, reporting and 16 // A TrackedPreference tracks changes to an individual preference, reporting and
16 // reacting to them according to preference-specific and browser-wide policies. 17 // reacting to them according to preference-specific and browser-wide policies.
17 class TrackedPreference { 18 class TrackedPreference {
18 public: 19 public:
19 virtual ~TrackedPreference() {} 20 virtual ~TrackedPreference() {}
20 21
21 // Notifies the underlying TrackedPreference about its new |value| which 22 // Notifies the underlying TrackedPreference about its new |value| which
22 // can update hashes in the corresponding hash store via |transaction|. 23 // can update hashes in the corresponding hash store via |transaction|.
23 virtual void OnNewValue(const base::Value* value, 24 virtual void OnNewValue(const base::Value* value,
24 PrefHashStoreTransaction* transaction) const = 0; 25 PrefHashStoreTransaction* transaction) const = 0;
25 26
26 // Verifies that the value of this TrackedPreference in |pref_store_contents| 27 // Verifies that the value of this TrackedPreference in |pref_store_contents|
27 // is valid. Responds to verification failures according to 28 // is valid. Responds to verification failures according to
28 // preference-specific and browser-wide policy and reports results to via UMA. 29 // preference-specific and browser-wide policy and reports results to via UMA.
29 // May use |transaction| to check/modify hashes in the corresponding hash 30 // May use |transaction| to check/modify hashes in the corresponding hash
30 // store. 31 // store.
erikwright (departed) 2014/05/14 00:39:26 If it won't be a constructor parameter (detail of
grt (UTC plus 2) 2014/05/14 18:57:22 Done.
31 virtual bool EnforceAndReport( 32 virtual bool EnforceAndReport(
32 base::DictionaryValue* pref_store_contents, 33 base::DictionaryValue* pref_store_contents,
33 PrefHashStoreTransaction* transaction) const = 0; 34 PrefHashStoreTransaction* transaction,
35 TrackedPreferenceValidationObserver* observer) const = 0;
34 }; 36 };
35 37
36 #endif // CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_H_ 38 #endif // CHROME_BROWSER_PREFS_TRACKED_TRACKED_PREFERENCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698