Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: src/parsing/parser.h

Issue 2665513002: [parser] Lift template literal invalid escape restriction (Closed)
Patch Set: rebase harder Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index 934068d8f51e1787dadaf44e9964829bc61d0b7d..99ead483b46cac653421f14390877c0f9e2664f4 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -586,7 +586,8 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
typedef TemplateLiteral* TemplateLiteralState;
TemplateLiteralState OpenTemplateLiteral(int pos);
- void AddTemplateSpan(TemplateLiteralState* state, bool tail);
+ void AddTemplateSpan(TemplateLiteralState* state, bool should_cook,
adamk 2017/02/07 20:55:13 Can you give this method a comment? Neither "shoul
bakkot1 2017/02/13 20:22:24 Done.
+ bool tail);
void AddTemplateExpression(TemplateLiteralState* state,
Expression* expression);
Expression* CloseTemplateLiteral(TemplateLiteralState* state, int start,

Powered by Google App Engine
This is Rietveld 408576698