Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: src/parsing/parser.h

Issue 2665513002: [parser] Lift template literal invalid escape restriction (Closed)
Patch Set: add test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index 668f0e7392a7fe64d2d348f6cb84c75918ee3276..e2223d9a7728e06f0d720a9f9b6798148631f41e 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -598,7 +598,15 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
typedef TemplateLiteral* TemplateLiteralState;
TemplateLiteralState OpenTemplateLiteral(int pos);
- void AddTemplateSpan(TemplateLiteralState* state, bool tail);
+ // "should_cook" means that the span can be "cooked": in tagged template
+ // literals, both the raw and "cooked" representations are available to user
+ // code ("cooked" meaning that escape sequences are converted to their
+ // interpreted values). With the --harmony-template-escapes flag, invalid
+ // escape sequences cause the cooked span to be represented by undefined,
+ // instead of being a syntax error.
+ // "tail" indicates that this span is the last in the literal.
+ void AddTemplateSpan(TemplateLiteralState* state, bool should_cook,
+ bool tail);
void AddTemplateExpression(TemplateLiteralState* state,
Expression* expression);
Expression* CloseTemplateLiteral(TemplateLiteralState* state, int start,
« no previous file with comments | « src/flag-definitions.h ('k') | src/parsing/parser.cc » ('j') | src/parsing/parser-base.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698