Add builders to APDU command class

device/u2f/u2f_apdu_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "u2f_apdu_command.h"
 #include "u2f_apdu_response.h"
 
 namespace device {
@@ skipping 163 matching lines @@
           U2fApduCommand::CreateFromMessage(expected)->GetEncodedCommand()));
 
   // Maximum data size
   std::vector<uint8_t> oversized(U2fApduCommand::kApduMaxDataLength);
   cmd->set_data(oversized);
   EXPECT_THAT(cmd->GetEncodedCommand(),
               testing::ContainerEq(
                   U2fApduCommand::CreateFromMessage(cmd->GetEncodedCommand())
                       ->GetEncodedCommand()));
 }
+
+TEST_F(U2fApduTest, TestBuildApdu) {

[juanlang (chromium.org), 2017/01/28 00:08:39]

BuildGetVersionCommand and BuildGetLegacyVersionCommand need tests too, please.

[Reilly Grant (use Gerrit), 2017/01/28 00:29:29]

Put each one in its own test method.

[Casey Piper, 2017/01/30 21:51:41]

Done.

[Casey Piper, 2017/01/30 21:51:41]

Done.

+  std::vector<uint8_t> appid(U2fApduCommand::kAppIdDigestLen, 0x01);
+  std::vector<uint8_t> challenge(U2fApduCommand::kChallengeDigestLen, 0xff);
+  scoped_refptr<U2fApduCommand> cmd =
+      U2fApduCommand::BuildRegisterCommand(appid, challenge);
+  ASSERT_NE(nullptr, cmd);
+  EXPECT_THAT(U2fApduCommand::CreateFromMessage(cmd->GetEncodedCommand())
+                  ->GetEncodedCommand(),
+              testing::ContainerEq(cmd->GetEncodedCommand()));
+  // Expect null result with appid.size() > kAppIdDigestLen
+  appid.push_back(0xff);
+  cmd = U2fApduCommand::BuildRegisterCommand(appid, challenge);
+  EXPECT_EQ(nullptr, cmd);
+
+  appid.pop_back();
+  std::vector<uint8_t> key_handle(U2fApduCommand::kMaxKeyHandleLength);
+  cmd = U2fApduCommand::BuildSignCommand(appid, challenge, key_handle);
+  ASSERT_NE(nullptr, cmd);
+  EXPECT_THAT(U2fApduCommand::CreateFromMessage(cmd->GetEncodedCommand())
+                  ->GetEncodedCommand(),
+              testing::ContainerEq(cmd->GetEncodedCommand()));
+  // Expect null result with appid.size() > kMaxKeyHandleLength
+  key_handle.push_back(0x0f);
+  cmd = U2fApduCommand::BuildSignCommand(appid, challenge, key_handle);
+  EXPECT_EQ(nullptr, cmd);
+}
 }  // namespace device