Issue 2665403002: Don't send 'Response.refactoringRequestCancelle' if the request is null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2665403002: Don't send 'Response.refactoringRequestCancelle' if the request is null. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't send 'Response.refactoringRequestCancelle' if the request is null. Not sure how to reproduce this, but saw this in the exceptions log. Just once, so must be a pretty event, but still. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/811d0caad2a0cbe11960b5b63dec518dc11f6cc2

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-02-01 18:06:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
811d0caad2a0cbe11960b5b63dec518dc11f6cc2 (presubmit successful).