LayoutTests/editing/text-iterator/findString-restarts-at-last-position.html - Issue 26654011: Fixing TestRunner::findString() so as to fix findString.html editing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/text-iterator/findString-restarts-at-last-position.html

Issue 26654011: Fixing TestRunner::findString() so as to fix findString.html editing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing missed out cases Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/text-iterator/findString.html ('K') | « LayoutTests/editing/text-iterator/findString-expected.txt ('k') | LayoutTests/editing/text-iterator/findString-restarts-at-last-position-expected.txt » ('j') | public/web/WebFindOptions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/text-iterator/findString-restarts-at-last-position.html

diff --git a/LayoutTests/editing/text-iterator/findString-restarts-at-last-position.html b/LayoutTests/editing/text-iterator/findString-restarts-at-last-position.html

index ac5bc8e86eac68d3fe8ab04c9a3d060da8a76c39..a0eb0d81afe6ce9f74a014a2a065dfef26daee1b 100644

--- a/LayoutTests/editing/text-iterator/findString-restarts-at-last-position.html

+++ b/LayoutTests/editing/text-iterator/findString-restarts-at-last-position.html

@@ -22,9 +22,10 @@ if (!window.testRunner)

testFailed('This test requires the testRunner object');

else {

shouldBeTrue('testRunner.findString("first_", [])');

- shouldBeTrue('testRunner.findString("first_step", [])');

+ shouldBeTrue('testRunner.findString("first_step", ["StartInSelection"])');

tkent 2013/10/17 23:31:30 Please explain why we need this change in the CL d

shouldBeTrue('testRunner.findString("last_step", [])');

shouldBeFalse('testRunner.findString("last_step", [])');

+ shouldBeTrue('testRunner.findString("last_step", ["WrapAround"])');

}

document.getElementById("console").style.removeProperty("visibility");