Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: ios/web_view/BUILD.gn

Issue 2665333002: Add a BUILD target and a script to build a public static library for ios/web_view. (Closed)
Patch Set: Slightly simplified a build rule. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web_view/internal/BUILD.gn » ('j') | ios/web_view/internal/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/BUILD.gn
diff --git a/ios/web_view/BUILD.gn b/ios/web_view/BUILD.gn
index 1755748783f025fd9447a2945e68dbeaa39c27f5..668e6cdb636dc7f691b01cd4667a490fd50dd89e 100644
--- a/ios/web_view/BUILD.gn
+++ b/ios/web_view/BUILD.gn
@@ -2,13 +2,33 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+config("web_view_config") {
+ libs = [
+ "$target_out_dir/libweb_view.a",
+
+ # //ios/web_view depends on sqlite3 provided by iOS.
+ "sqlite3",
+ ]
+}
+
# Public target that should be used to depend on web_view. Only give access
# to the web_view public headers while still linking with the implementation.
-group("web_view") {
+#
+# The generated libweb_view.a can be also linked to apps outside Chromium
michaeldo 2017/02/07 18:14:20 The second sentence provides enough information, p
Hiroshi Ichikawa 2017/02/08 01:16:21 Done.
+# code base. This is a complete static library (containing all dependencies),
+# and it doesn't expose internal symbols to reduce risk of symbol conflict.
+copy("web_view") {
public_deps = [
"//ios/web_view/public",
]
deps = [
- "//ios/web_view/internal",
+ "//ios/web_view/internal:lib_web_view",
+ ]
+ sources = [
+ "$target_out_dir/internal/libweb_view.a",
+ ]
+ outputs = [
+ "$target_out_dir/libweb_view.a",
]
+ public_configs = [ ":web_view_config" ]
}
« no previous file with comments | « no previous file | ios/web_view/internal/BUILD.gn » ('j') | ios/web_view/internal/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698