Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: ios/web_view/internal/BUILD.gn

Issue 2665333002: Add a BUILD target and a script to build a public static library for ios/web_view. (Closed)
Patch Set: Slightly simplified a build rule. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("internal") { 5 _deps = [
6 visibility = [ 6 "//base",
7 "//ios/web_view", 7 "//components/pref_registry",
8 "//ios/web_view/internal/*", 8 "//components/prefs",
9 ] 9 "//components/translate/core/browser",
10 "//components/translate/core/common",
11 "//ios/net",
12 "//ios/web",
13 "//ios/web:user_agent",
14 "//ios/web/public/app",
15 "//ios/web_view/internal/translate",
16 "//ios/web_view/public",
17 "//net",
18 "//net:extras",
19 "//ui/base",
20 "//url",
21 ]
10 22
23 # An incomplete static library for //ios/web_view. Used as an input of
24 # :lib_web_view.
25 static_library("web_view_incomplete") {
26 visibility = [ ":*" ]
11 sources = [ 27 sources = [
12 "criwv.mm", 28 "criwv.mm",
13 "criwv_browser_state.h", 29 "criwv_browser_state.h",
14 "criwv_browser_state.mm", 30 "criwv_browser_state.mm",
15 "criwv_network_delegate.cc", 31 "criwv_network_delegate.cc",
16 "criwv_network_delegate.h", 32 "criwv_network_delegate.h",
17 "criwv_url_request_context_getter.h", 33 "criwv_url_request_context_getter.h",
18 "criwv_url_request_context_getter.mm", 34 "criwv_url_request_context_getter.mm",
19 "criwv_web_client.h", 35 "criwv_web_client.h",
20 "criwv_web_client.mm", 36 "criwv_web_client.mm",
21 "criwv_web_main_delegate.h", 37 "criwv_web_main_delegate.h",
22 "criwv_web_main_delegate.mm", 38 "criwv_web_main_delegate.mm",
23 "criwv_web_main_parts.h", 39 "criwv_web_main_parts.h",
24 "criwv_web_main_parts.mm", 40 "criwv_web_main_parts.mm",
25 "criwv_web_view.mm", 41 "criwv_web_view.mm",
26 "criwv_web_view_internal.h", 42 "criwv_web_view_internal.h",
27 "pref_names.cc", 43 "pref_names.cc",
28 "pref_names.h", 44 "pref_names.h",
29 ] 45 ]
30 deps = [ 46 deps = _deps
31 "//base",
32 "//components/pref_registry",
33 "//components/prefs",
34 "//components/translate/core/browser",
35 "//components/translate/core/common",
36 "//ios/net",
37 "//ios/web",
38 "//ios/web:user_agent",
39 "//ios/web/public/app",
40 "//ios/web_view/internal/translate",
41 "//ios/web_view/public",
42 "//net",
43 "//net:extras",
44 "//ui/base",
45 "//url",
46 ]
47 allow_circular_includes_from = [ "//ios/web_view/internal/translate" ] 47 allow_circular_includes_from = [ "//ios/web_view/internal/translate" ]
48 } 48 }
49
50 # A static library which contains all dependencies of :web_view_incomplete.
51 # Used to build "web_view".
michaeldo 2017/02/07 18:14:20 Please remove the second comment line ("Used to bu
Hiroshi Ichikawa 2017/02/08 01:16:21 Done.
52 static_library("deps_complete") {
53 visibility = [ ":*" ]
54 complete_static_lib = true
55 deps = _deps
56 }
57
58 # A static library expected to be used by apps outside Chromium code base.
michaeldo 2017/02/07 18:14:20 I suggest removing these comments. The public inte
Hiroshi Ichikawa 2017/02/08 01:16:21 Done.
59 # This is a complete static library (containing all dependencies),
60 # and it doesn't expose internal symbols to reduce risk of symbol conflict.
61 #
62 # //ios/web_view is an alias of this library.
63 #
64 # TODO(ichikawa): Support building a universal binary.
65 action("lib_web_view") {
66 visibility = [
67 "//ios/web_view",
68 "//ios/web_view/internal/*",
69 ]
70 script = "hide_symbols.py"
71 deps = [
72 ":deps_complete",
73 ":web_view_incomplete",
74 ]
75 outputs = [
76 "$target_out_dir/libweb_view.a",
77 "$target_out_dir/libweb_view.o",
78 ]
79 args = [
80 "--input_lib",
81 rebase_path("$target_out_dir/libweb_view_incomplete.a", root_build_dir),
82 "--deps_lib",
83 rebase_path("$target_out_dir/libdeps_complete.a", root_build_dir),
84 "--output_obj",
85 rebase_path("$target_out_dir/libweb_view.o", root_build_dir),
86 "--output_lib",
87 rebase_path("$target_out_dir/libweb_view.a", root_build_dir),
88 "--current_cpu",
89 current_cpu,
90 ]
91 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698