Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266533004: Create unprefixed versions of pointerlockchange & pointerlockerror events. (Closed)

Created:
6 years, 7 months ago by scheib
Modified:
6 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, chrishtr, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, ojan, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

Create unprefixed versions of pointerlockchange & pointerlockerror events. Part of unprefixing the entire pointer lock API. LayoutTests are duplicated into new files with suffix "-prefixed" and the originals are modified to use the new unprefixed API. BUG=359738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -94 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-prefixed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-prefixed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-prefixed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-prefixed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-prefixed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-prefixed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-prefixed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/iframe-sandboxed-prefixed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/pointerlockelement-different-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/pointer-lock/pointerlockelement-different-origin-prefixed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/pointerlockelement-different-origin-prefixed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/pointerlockelement-same-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/pointer-lock/pointerlockelement-same-origin-prefixed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/pointerlockelement-same-origin-prefixed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-prefixed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-prefixed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/resources/pointer-lock/iframe-allows-inner-iframe-prefixed.html View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/resources/pointer-lock/iframe-common.js View 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/http/tests/resources/pointer-lock/iframe-common-prefixed.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/http/tests/resources/pointer-lock/inner-iframe-prefixed.html View 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness.js View 1 chunk +6 lines, -6 lines 0 comments Download
A + LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness-prefixed.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/bug90391-move-then-window-open-crash.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/lock-already-locked.html View 2 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/pointer-lock/lock-already-locked-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/pointer-lock/lock-already-locked-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/lock-already-locked-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/lock-element-not-in-dom-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/lock-element-not-in-dom-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/lock-element-not-in-dom-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/locked-element-removed-from-dom-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/pointer-lock/locked-element-removed-from-dom-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/locked-element-removed-from-dom-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/pointer-lock/mouse-event-api-prefixed.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/pointer-lock/mouse-event-api-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/mouse-event-delivery.html View 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/pointer-lock/mouse-event-delivery-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/pointer-lock/mouse-event-delivery-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/mouse-event-delivery-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/pointer-lock-api.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/pointer-lock/pointer-lock-api-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/pointer-lock/pointer-lock-api-prefixed.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/pointer-lock/pointer-lock-api-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/pointerlockchange-event-on-lock-lost-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/pointer-lock/pointerlockchange-event-on-lock-lost-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/pointerlockchange-event-on-lock-lost-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
A + LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/pointer-lock/pointerlockelement-null-when-pending-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/pointer-lock/pointerlockelement-null-when-pending-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/pointer-lock/pointerlockelement-null-when-pending-prefixed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/PointerLockController.cpp View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheib
6 years, 7 months ago (2014-04-30 19:30:54 UTC) #1
eseidel
lgtm OK. I might have just removed the prefixed tests, but I guess we can ...
6 years, 7 months ago (2014-05-06 19:54:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/266533004/1
6 years, 7 months ago (2014-05-06 19:54:54 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 20:39:29 UTC) #4
Message was sent while issue was closed. 
Change committed as 173427

Powered by Google App Engine
This is Rietveld 408576698