components/password_manager/core/browser/password_autofill_manager.cc - Issue 2665313002: Add a counter for clicking on Form-Not-Secure warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 2665313002: Add a counter for clicking on Form-Not-Secure warnings (Closed)

Patch Set: rebase fixup again Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_metrics_unittest.cc ('k') | components/password_manager/core/browser/password_autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc

index 25c1e06ab48865f078e29237d48c7613f6304772..6b7cbfbd435381f9694a2c452f92916902ffcd36 100644

--- a/components/password_manager/core/browser/password_autofill_manager.cc

+++ b/components/password_manager/core/browser/password_autofill_manager.cc

@@ -292,6 +292,7 @@ void PasswordAutofillManager::DidAcceptSuggestion(const base::string16& value,

int identifier,

int position) {

if (identifier == autofill::POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE) {

+ metrics_util::LogShowedHttpNotSecureExplanation();

autofill_client_->ShowHttpNotSecureExplanation();

} else {

bool success =