Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1972)

Unified Diff: net/spdy/spdy_session_key.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: address bnc comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session_key.cc
diff --git a/net/spdy/spdy_session_key.cc b/net/spdy/spdy_session_key.cc
index 8b2fcbcc81f879f7e8595d0e986052139f346149..a07ed7e8d1945686ecf491a6633a5330c344da68 100644
--- a/net/spdy/spdy_session_key.cc
+++ b/net/spdy/spdy_session_key.cc
@@ -7,6 +7,8 @@
#include <tuple>
#include "base/logging.h"
+#include "base/trace_event/memory_usage_estimator.h"
+#include "net/base/host_port_pair.h"
namespace net {
@@ -49,4 +51,9 @@ bool SpdySessionKey::Equals(const SpdySessionKey& other) const {
host_port_proxy_pair_.second == other.host_port_proxy_pair_.second;
}
+size_t SpdySessionKey::EstimateMemoryUsage() const {
+ return HostPortPair::EstimateMemoryUsage(host_port_proxy_pair_.first) +
DmitrySkiba 2017/02/02 18:16:27 Why EMU() is not an instance method in HostPortPai
xunjieli 2017/02/03 22:25:10 Done.
+ base::trace_event::EstimateMemoryUsage(host_port_proxy_pair_.second);
+}
+
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698