Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: net/spdy/hpack/hpack_encoder.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: address bnc comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/hpack/hpack_encoder.cc
diff --git a/net/spdy/hpack/hpack_encoder.cc b/net/spdy/hpack/hpack_encoder.cc
index 0ec5e8f67d4a3cdabc71b07f0c86dbeca509a343..9e215160ceeb2fba9cc217178f9d3edabfdb036d 100644
--- a/net/spdy/hpack/hpack_encoder.cc
+++ b/net/spdy/hpack/hpack_encoder.cc
@@ -132,6 +132,11 @@ void HpackEncoder::ApplyHeaderTableSizeSetting(size_t size_setting) {
should_emit_table_size_ = true;
}
+size_t HpackEncoder::EstimateMemoryUsage() const {
+ // |huffman_table_| is a singleton. It's accounted for in spdy_session_pool.cc
+ return header_table_.size() + output_stream_.size();
DmitrySkiba 2017/02/02 18:16:27 They should both be EMUs - header_table_.size() it
xunjieli 2017/02/03 22:25:09 Done.
+}
+
void HpackEncoder::EncodeRepresentations(RepresentationIterator* iter,
string* output) {
MaybeEmitTableSize();

Powered by Google App Engine
This is Rietveld 408576698