Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: net/spdy/buffered_spdy_framer.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: address bnc comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/buffered_spdy_framer.cc
diff --git a/net/spdy/buffered_spdy_framer.cc b/net/spdy/buffered_spdy_framer.cc
index fc583686fd94c2c19872b4ec075dd39eeec83c8f..793fdeb6f8077b7f252089da4264816ef8de14cb 100644
--- a/net/spdy/buffered_spdy_framer.cc
+++ b/net/spdy/buffered_spdy_framer.cc
@@ -9,6 +9,7 @@
#include "base/logging.h"
#include "base/strings/string_util.h"
+#include "base/trace_event/memory_usage_estimator.h"
namespace net {
@@ -334,6 +335,12 @@ SpdyPriority BufferedSpdyFramer::GetHighestPriority() const {
return spdy_framer_.GetHighestPriority();
}
+size_t BufferedSpdyFramer::EstimateMemoryUsage() const {
+ return base::trace_event::EstimateMemoryUsage(spdy_framer_) +
+ base::trace_event::EstimateMemoryUsage(header_buffer_) +
+ base::trace_event::EstimateMemoryUsage(coalescer_);
DmitrySkiba 2017/02/02 18:16:27 I would also add control_frame_fields_ and goaway
xunjieli 2017/02/03 22:25:09 Done for goaway_fields_. ControlFrameFields do not
+}
+
void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) {
header_buffer_.clear();
header_buffer_valid_ = true;

Powered by Google App Engine
This is Rietveld 408576698