Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: net/spdy/buffered_spdy_framer.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: Address Bence comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/buffered_spdy_framer.cc
diff --git a/net/spdy/buffered_spdy_framer.cc b/net/spdy/buffered_spdy_framer.cc
index fbedb84c1e49a12b334bbed44db7ef79f9bb5e38..52668d27de174c0b56af36efc97e672acd5ad1fe 100644
--- a/net/spdy/buffered_spdy_framer.cc
+++ b/net/spdy/buffered_spdy_framer.cc
@@ -9,6 +9,7 @@
#include "base/logging.h"
#include "base/strings/string_util.h"
+#include "base/trace_event/memory_usage_estimator.h"
namespace net {
@@ -334,6 +335,14 @@ SpdyPriority BufferedSpdyFramer::GetHighestPriority() const {
return spdy_framer_.GetHighestPriority();
}
+size_t BufferedSpdyFramer::EstimateMemoryUsage() const {
+ return base::trace_event::EstimateMemoryUsage(spdy_framer_) +
+ base::trace_event::EstimateMemoryUsage(header_buffer_) +
+ base::trace_event::EstimateMemoryUsage(coalescer_) +
+ base::trace_event::EstimateMemoryUsage(control_frame_fields_) +
+ base::trace_event::EstimateMemoryUsage(goaway_fields_);
+}
+
void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) {
header_buffer_.clear();
header_buffer_valid_ = true;
@@ -341,4 +350,8 @@ void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) {
DCHECK_NE(header_stream_id_, SpdyFramer::kInvalidStream);
}
+size_t BufferedSpdyFramer::GoAwayFields::EstimateMemoryUsage() const {
+ return base::trace_event::EstimateMemoryUsage(debug_data);
+}
+
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698