Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: net/http2/hpack/decoder/http2_hpack_decoder.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http2/hpack/decoder/http2_hpack_decoder.cc
diff --git a/net/http2/hpack/decoder/http2_hpack_decoder.cc b/net/http2/hpack/decoder/http2_hpack_decoder.cc
index 390d8287c73d2977d19bdedfef6f00b73f35b5f0..ff847600ef810cf332b1764fe5231665fdb9f9e2 100644
--- a/net/http2/hpack/decoder/http2_hpack_decoder.cc
+++ b/net/http2/hpack/decoder/http2_hpack_decoder.cc
@@ -116,6 +116,10 @@ bool Http2HpackDecoder::error_detected() {
return error_detected_;
}
+size_t Http2HpackDecoder::EstimateMemoryUsage() const {
+ return entry_buffer_.EstimateMemoryUsage();
Bence 2017/02/05 19:11:23 I thought EstimateMemoryUsage(entry_buffer_) is pr
xunjieli 2017/02/06 14:54:56 Done. Oops sorry. Good catch! I missed this one an
+}
+
void Http2HpackDecoder::ReportError(StringPiece error_message) {
DVLOG(3) << "Http2HpackDecoder::ReportError is new="
<< (!error_detected_ ? "true" : "false")

Powered by Google App Engine
This is Rietveld 408576698