Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider.

net/spdy/spdy_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_stream.h"
 
 #include <limits>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "base/trace_event/memory_usage_estimator.h"
 #include "base/values.h"
 #include "net/log/net_log.h"
 #include "net/log/net_log_capture_mode.h"
 #include "net/log/net_log_event_type.h"
 #include "net/spdy/spdy_buffer_producer.h"
 #include "net/spdy/spdy_http_utils.h"
 #include "net/spdy/spdy_session.h"
 
 namespace net {
 
@@ skipping 781 matching lines @@
   if (type_ == SPDY_PUSH_STREAM) {
     load_timing_info->push_start = recv_first_byte_time_;
     bool done_receiving = IsClosed() || (!pending_recv_data_.empty() &&
                                          !pending_recv_data_.back());
     if (done_receiving)
       load_timing_info->push_end = recv_last_byte_time_;
   }
   return result;
 }
 
+size_t SpdyStream::EstimateMemoryUsage() const {
+  return base::trace_event::EstimateMemoryUsage(url_) +
+         base::trace_event::EstimateMemoryUsage(request_headers_);

[DmitrySkiba, 2017/02/02 18:16:27]

Please also estimate url_from_header_block_ and pending_recv_data_.

Please add TODO regarding pending_send_data_ (scoped_refptr).

[xunjieli, 2017/02/03 22:25:10]

Done.

+}
+
 void SpdyStream::UpdateHistograms() {
   // We need at least the receive timers to be filled in, as otherwise
   // metrics can be bogus.
   if (recv_first_byte_time_.is_null() || recv_last_byte_time_.is_null())
     return;
 
   base::TimeTicks effective_send_time;
   if (type_ == SPDY_PUSH_STREAM) {
     // Push streams shouldn't have |send_time_| filled in.
     DCHECK(send_time_.is_null());
@@ skipping 108 matching lines @@
       description = base::StringPrintf("Unknown state 0x%08X (%u)", state,
                                        state);
       break;
   }
   return description;
 }
 
 #undef STATE_CASE
 
 }  // namespace net