Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider.

net/spdy/spdy_framer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_framer.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <cctype>
 #include <ios>
 #include <iterator>
 #include <list>
 #include <memory>
 #include <new>
 #include <string>
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
+#include "base/trace_event/memory_usage_estimator.h"
 #include "net/quic/core/quic_flags.h"
 #include "net/spdy/hpack/hpack_constants.h"
 #include "net/spdy/hpack/hpack_decoder.h"
 #include "net/spdy/hpack/hpack_decoder2.h"
 #include "net/spdy/hpack/hpack_decoder3.h"
 #include "net/spdy/http2_frame_decoder_adapter.h"
 #include "net/spdy/spdy_bitmasks.h"
 #include "net/spdy/spdy_bug_tracker.h"
 #include "net/spdy/spdy_flags.h"
 #include "net/spdy/spdy_frame_builder.h"
@@ skipping 2376 matching lines @@
   } else {
     GetHpackDecoder()->SetHeaderTableDebugVisitor(std::move(visitor));
   }
 }
 
 void SpdyFramer::SetEncoderHeaderTableDebugVisitor(
     std::unique_ptr<HpackHeaderTable::DebugVisitorInterface> visitor) {
   GetHpackEncoder()->SetHeaderTableDebugVisitor(std::move(visitor));
 }
 
+size_t SpdyFramer::EstimateMemoryUsage() const {
+  size_t memory_estimate =
+      current_frame_buffer_.len() + settings_scratch_.buffer.len();

[DmitrySkiba, 2017/02/02 18:16:27]

CharBuffer should implement EMU (where it should return capacity, not length),
that would also make estimating altsvc_scratch_ trivial.

Please also estimate decoder_adapter_ (i.e. add EMUs to SpdyFramerDecoderAdapter
and its subclasses).

[xunjieli, 2017/02/03 22:25:09]

Done.

+  if (altsvc_scratch_)
+    memory_estimate += altsvc_scratch_->len();
+  memory_estimate += base::trace_event::EstimateMemoryUsage(hpack_encoder_) +
+                     base::trace_event::EstimateMemoryUsage(hpack_decoder_);
+  return memory_estimate;
+}
+
 void SpdyFramer::UpdateHeaderEncoderTableSize(uint32_t value) {
   GetHpackEncoder()->ApplyHeaderTableSizeSetting(value);
 }
 
 void SpdyFramer::UpdateHeaderDecoderTableSize(uint32_t value) {
   GetHpackDecoder()->ApplyHeaderTableSizeSetting(value);
 }
 
 size_t SpdyFramer::header_encoder_table_size() const {
   if (hpack_encoder_ == nullptr) {
@@ skipping 10 matching lines @@
   builder->WriteUInt32(header_block.size());
 
   // Serialize each header.
   for (const auto& header : header_block) {
     builder->WriteStringPiece32(base::ToLowerASCII(header.first));
     builder->WriteStringPiece32(header.second);
   }
 }
 
 }  // namespace net