Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: net/spdy/spdy_write_queue.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« net/spdy/spdy_session.cc ('K') | « net/spdy/spdy_write_queue.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_write_queue.h" 5 #include "net/spdy/spdy_write_queue.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 for (int i = MINIMUM_PRIORITY; i <= MAXIMUM_PRIORITY; ++i) { 149 for (int i = MINIMUM_PRIORITY; i <= MAXIMUM_PRIORITY; ++i) {
150 for (auto it = queue_[i].begin(); it != queue_[i].end(); ++it) { 150 for (auto it = queue_[i].begin(); it != queue_[i].end(); ++it) {
151 erased_buffer_producers.push_back(std::move(it->frame_producer)); 151 erased_buffer_producers.push_back(std::move(it->frame_producer));
152 } 152 }
153 queue_[i].clear(); 153 queue_[i].clear();
154 } 154 }
155 removing_writes_ = false; 155 removing_writes_ = false;
156 } 156 }
157 157
158 size_t SpdyWriteQueue::EstimateMemoryUsage() const {
159 // TODO(xunjieli): return allocation from |queue_| once
160 // memory_usage_estimator.h supports std::deque. crbug.com/669108.
Bence 2017/02/02 14:15:19 Nit: https://crbug.com/669108.
xunjieli 2017/02/02 14:53:42 Done.
161 return 0;
162 }
163
158 } // namespace net 164 } // namespace net
OLDNEW
« net/spdy/spdy_session.cc ('K') | « net/spdy/spdy_write_queue.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698