Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: net/spdy/spdy_write_queue_unittest.cc

Issue 2665283003: Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_write_queue.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_write_queue.h" 5 #include "net/spdy/spdy_write_queue.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 #include <cstring> 8 #include <cstring>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
11 #include <utility> 11 #include <utility>
12 12
13 #include "base/logging.h"
13 #include "base/memory/ref_counted.h" 14 #include "base/memory/ref_counted.h"
14 #include "base/strings/string_number_conversions.h" 15 #include "base/strings/string_number_conversions.h"
15 #include "net/base/request_priority.h" 16 #include "net/base/request_priority.h"
16 #include "net/log/net_log_with_source.h" 17 #include "net/log/net_log_with_source.h"
17 #include "net/spdy/spdy_buffer_producer.h" 18 #include "net/spdy/spdy_buffer_producer.h"
18 #include "net/spdy/spdy_stream.h" 19 #include "net/spdy/spdy_stream.h"
19 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
20 #include "url/gurl.h" 21 #include "url/gurl.h"
21 22
22 namespace net { 23 namespace net {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 RequeingBufferProducer(SpdyWriteQueue* queue) { 55 RequeingBufferProducer(SpdyWriteQueue* queue) {
55 buffer_.reset(new SpdyBuffer(kOriginal, arraysize(kOriginal))); 56 buffer_.reset(new SpdyBuffer(kOriginal, arraysize(kOriginal)));
56 buffer_->AddConsumeCallback( 57 buffer_->AddConsumeCallback(
57 base::Bind(RequeingBufferProducer::ConsumeCallback, queue)); 58 base::Bind(RequeingBufferProducer::ConsumeCallback, queue));
58 } 59 }
59 60
60 std::unique_ptr<SpdyBuffer> ProduceBuffer() override { 61 std::unique_ptr<SpdyBuffer> ProduceBuffer() override {
61 return std::move(buffer_); 62 return std::move(buffer_);
62 } 63 }
63 64
65 size_t EstimateMemoryUsage() const override {
66 NOTREACHED();
67 return 0;
68 }
69
64 static void ConsumeCallback(SpdyWriteQueue* queue, 70 static void ConsumeCallback(SpdyWriteQueue* queue,
65 size_t size, 71 size_t size,
66 SpdyBuffer::ConsumeSource source) { 72 SpdyBuffer::ConsumeSource source) {
67 std::unique_ptr<SpdyBufferProducer> producer( 73 std::unique_ptr<SpdyBufferProducer> producer(
68 new SimpleBufferProducer(std::unique_ptr<SpdyBuffer>( 74 new SimpleBufferProducer(std::unique_ptr<SpdyBuffer>(
69 new SpdyBuffer(kRequeued, arraysize(kRequeued))))); 75 new SpdyBuffer(kRequeued, arraysize(kRequeued)))));
70 76
71 queue->Enqueue(MEDIUM, RST_STREAM, std::move(producer), 77 queue->Enqueue(MEDIUM, RST_STREAM, std::move(producer),
72 base::WeakPtr<SpdyStream>()); 78 base::WeakPtr<SpdyStream>());
73 } 79 }
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 std::unique_ptr<SpdyBufferProducer> producer; 367 std::unique_ptr<SpdyBufferProducer> producer;
362 base::WeakPtr<SpdyStream> weak_stream; 368 base::WeakPtr<SpdyStream> weak_stream;
363 369
364 EXPECT_TRUE(queue.Dequeue(&frame_type, &producer, &weak_stream)); 370 EXPECT_TRUE(queue.Dequeue(&frame_type, &producer, &weak_stream));
365 EXPECT_EQ(string(kRequeued), producer->ProduceBuffer()->GetRemainingData()); 371 EXPECT_EQ(string(kRequeued), producer->ProduceBuffer()->GetRemainingData());
366 } 372 }
367 373
368 } // namespace 374 } // namespace
369 375
370 } // namespace net 376 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_write_queue.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698