Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider.

net/spdy/spdy_framer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_framer.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <cctype>
 #include <ios>
 #include <iterator>
 #include <list>
 #include <memory>
 #include <new>
 #include <string>
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
+#include "base/trace_event/memory_usage_estimator.h"
 #include "net/quic/core/quic_flags.h"
 #include "net/spdy/hpack/hpack_constants.h"
 #include "net/spdy/hpack/hpack_decoder.h"
 #include "net/spdy/hpack/hpack_decoder2.h"
 #include "net/spdy/hpack/hpack_decoder3.h"
 #include "net/spdy/http2_frame_decoder_adapter.h"
 #include "net/spdy/spdy_bitmasks.h"
 #include "net/spdy/spdy_bug_tracker.h"
 #include "net/spdy/spdy_flags.h"
 #include "net/spdy/spdy_frame_builder.h"
@@ skipping 521 matching lines @@
 void SpdyFramer::CharBuffer::CopyFrom(const char* data, size_t size) {
   DCHECK_GE(capacity_, len_ + size);
   memcpy(buffer_.get() + len_, data, size);
   len_ += size;
 }
 
 void SpdyFramer::CharBuffer::Rewind() {
   len_ = 0;
 }
 
+size_t SpdyFramer::CharBuffer::EstimateMemoryUsage() const {
+  return capacity_;
+}
+
 SpdyFramer::SpdySettingsScratch::SpdySettingsScratch()
     : buffer(8), last_setting_id(-1) {}
 
 void SpdyFramer::SpdySettingsScratch::Reset() {
   buffer.Rewind();
   last_setting_id = -1;
 }
 
+size_t SpdyFramer::SpdySettingsScratch::EstimateMemoryUsage() const {
+  return base::trace_event::EstimateMemoryUsage(buffer);
+}
+
 SpdyFrameType SpdyFramer::ValidateFrameHeader(bool is_control_frame,
                                               int frame_type_field,
                                               size_t payload_length_field) {
   if (!IsDefinedFrameType(frame_type_field)) {
     // We ignore unknown frame types for extensibility, as long as
     // the rest of the control frame header is valid.
     // We rely on the visitor to check validity of current_frame_stream_id_.
     bool valid_stream =
         visitor_->OnUnknownFrame(current_frame_stream_id_, frame_type_field);
     if (expect_continuation_) {
@@ skipping 1761 matching lines @@
   } else {
     GetHpackDecoder()->SetHeaderTableDebugVisitor(std::move(visitor));
   }
 }
 
 void SpdyFramer::SetEncoderHeaderTableDebugVisitor(
     std::unique_ptr<HpackHeaderTable::DebugVisitorInterface> visitor) {
   GetHpackEncoder()->SetHeaderTableDebugVisitor(std::move(visitor));
 }
 
+size_t SpdyFramer::EstimateMemoryUsage() const {
+  return base::trace_event::EstimateMemoryUsage(current_frame_buffer_) +
+         base::trace_event::EstimateMemoryUsage(settings_scratch_) +
+         base::trace_event::EstimateMemoryUsage(altsvc_scratch_) +
+         base::trace_event::EstimateMemoryUsage(hpack_encoder_) +
+         base::trace_event::EstimateMemoryUsage(hpack_decoder_) +
+         base::trace_event::EstimateMemoryUsage(decoder_adapter_);
+}
+
 void SpdyFramer::UpdateHeaderEncoderTableSize(uint32_t value) {
   GetHpackEncoder()->ApplyHeaderTableSizeSetting(value);
 }
 
 void SpdyFramer::UpdateHeaderDecoderTableSize(uint32_t value) {
   GetHpackDecoder()->ApplyHeaderTableSizeSetting(value);
 }
 
 size_t SpdyFramer::header_encoder_table_size() const {
   if (hpack_encoder_ == nullptr) {
@@ skipping 10 matching lines @@
   builder->WriteUInt32(header_block.size());
 
   // Serialize each header.
   for (const auto& header : header_block) {
     builder->WriteStringPiece32(base::ToLowerASCII(header.first));
     builder->WriteStringPiece32(header.second);
   }
 }
 
 }  // namespace net