Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider.

net/spdy/hpack/hpack_decoder.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/hpack/hpack_decoder.h"
 
 #include <utility>
 
 #include "base/logging.h"
+#include "base/trace_event/memory_usage_estimator.h"
 #include "net/spdy/hpack/hpack_constants.h"
 #include "net/spdy/hpack/hpack_entry.h"
 #include "net/spdy/spdy_flags.h"
 
 namespace net {
 
 using base::StringPiece;
 using std::string;
 
 HpackDecoder::HpackDecoder()
@@ skipping 89 matching lines @@
 void HpackDecoder::SetHeaderTableDebugVisitor(
     std::unique_ptr<HpackHeaderTable::DebugVisitorInterface> visitor) {
   header_table_.set_debug_visitor(std::move(visitor));
 }
 
 void HpackDecoder::set_max_decode_buffer_size_bytes(
     size_t max_decode_buffer_size_bytes) {
   max_decode_buffer_size_bytes_ = max_decode_buffer_size_bytes;
 }
 
+size_t HpackDecoder::EstimateMemoryUsage() const {
+  return header_table_.size() +

[DmitrySkiba, 2017/02/06 18:02:34]

HpackHeaderTable has EMU now, so this should be EMU(header_table_).

[xunjieli, 2017/02/08 15:42:50]

Done.

+         base::trace_event::EstimateMemoryUsage(headers_block_buffer_) +
+         base::trace_event::EstimateMemoryUsage(decoded_block_) +
+         base::trace_event::EstimateMemoryUsage(key_buffer_) +
+         base::trace_event::EstimateMemoryUsage(value_buffer_);
+}
+
 bool HpackDecoder::HandleHeaderRepresentation(StringPiece name,
                                               StringPiece value) {
   size_updates_allowed_ = false;
   total_header_bytes_ += name.size() + value.size();
 
   if (handler_ == nullptr) {
     decoded_block_.AppendValueOrAddHeader(name, value);
   } else {
     DCHECK(decoded_block_.empty());
     handler_->OnHeader(name, value);
@@ skipping 138 matching lines @@
   } else if (input_stream->MatchPrefixAndConsume(
                  kStringLiteralIdentityEncoded)) {
     return input_stream->DecodeNextIdentityString(output);
   } else {
     DVLOG(1) << "String literal is neither Huffman nor identity encoded!";
     return false;
   }
 }
 
 }  // namespace net