Streamline AnalysisDriver status tracking.

Streamline AnalysisDriver status tracking.

- Removed AnalysisDriver.status stream.  Outside of tests, we weren't
  using it.  Inside of tests, it was easy to switch to
  AnalysisDriverScheduler.status.

- Moved waitForIdle from AnalysisDriver to AnalysisDriverScheduler.

- Added a mechanism to ensure that AnalysisDriverScheduler.waitForIdle
  really waits for idle, even if AnalysisDriverScheduler.status hasn't
  been notified that we are analyzing yet.  This mechanism does the
  right thing even if we later discover that there is no analysis to
  be done (and so no event is ever sent to
  AnalysisDriverScheduler.status).

- Removed an unnecessary check from the loop in
  AnalysisDriverScheduler._run().

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/6f0f50dc1ed5820bdbb5b6bf5f8c93baef97d4cb

[Paul Berry, 2017-01-31 23:46:47]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-02-01 00:35:58]

LGTM

https://codereview.chromium.org/2665263002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/status.dart (right):

https://codereview.chromium.org/2665263002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/status.dart:103: * Send a notifications to
the [stream] that the driver started analyzing.
Now probably that "a driver" started analyzing.
Or maybe don't mention drivers here and elsewhere in this class.

[Paul Berry, 2017-02-01 17:17:34]

https://codereview.chromium.org/2665263002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/status.dart (right):

https://codereview.chromium.org/2665263002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/status.dart:103: * Send a notifications to
the [stream] that the driver started analyzing.
On 2017/02/01 00:35:58, scheglov wrote:
> Now probably that "a driver" started analyzing.
> Or maybe don't mention drivers here and elsewhere in this class.

Done.

[Paul Berry, 2017-02-01 17:22:57]

Description was changed from

==========
Streamline AnalysisDriver status tracking.

- Removed AnalysisDriver.status stream.  Outside of tests, we weren't
  using it.  Inside of tests, it was easy to switch to
  AnalysisDriverScheduler.status.

- Moved waitForIdle from AnalysisDriver to AnalysisDriverScheduler.

- Added a mechanism to ensure that AnalysisDriverScheduler.waitForIdle
  really waits for idle, even if AnalysisDriverScheduler.status hasn't
  been notified that we are analyzing yet.  This mechanism does the
  right thing even if we later discover that there is no analysis to
  be done (and so no event is ever sent to
  AnalysisDriverScheduler.status).

- Removed an unnecessary check from the loop in
  AnalysisDriverScheduler._run().
==========

to

==========
Streamline AnalysisDriver status tracking.

- Removed AnalysisDriver.status stream.  Outside of tests, we weren't
  using it.  Inside of tests, it was easy to switch to
  AnalysisDriverScheduler.status.

- Moved waitForIdle from AnalysisDriver to AnalysisDriverScheduler.

- Added a mechanism to ensure that AnalysisDriverScheduler.waitForIdle
  really waits for idle, even if AnalysisDriverScheduler.status hasn't
  been notified that we are analyzing yet.  This mechanism does the
  right thing even if we later discover that there is no analysis to
  be done (and so no event is ever sent to
  AnalysisDriverScheduler.status).

- Removed an unnecessary check from the loop in
  AnalysisDriverScheduler._run().

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6f0f50dc1ed5820bdbb5b6bf5f8c93baef97d4cb
==========

[Paul Berry, 2017-02-01 17:22:59]

Committed patchset #1 (id:1) manually as
6f0f50dc1ed5820bdbb5b6bf5f8c93baef97d4cb (presubmit successful).